test: Install podman 2.0.4 from updates-testing #478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoids running into the API breakage of 2.0.3: containers/podman#7078
|
This should unblock cockpit-project/bots#1109 |
2 tasks
marusak
reviewed
Aug 3, 2020
| @@ -46,8 +46,10 @@ if [ -d /var/tmp/debian ]; then | |||
| systemctl disable docker.service io.podman.service | |||
| fi | |||
|
|
|||
| # HACK: avoid leaking processes with podman < 2.0.4; see https://github.com/containers/podman/commit/2b6dd3fb4384 | |||
| sed -i '/KillMode=process/d; s/Type=oneshot/Type=simple/' /lib/systemd/user/podman.service /lib/systemd/system/podman.service | |||
| if rpm -q podman >/dev/null 2>&1; then | |||
There was a problem hiding this comment.
Why not using 'else' branch? Seems a bit clearer but just nitpick of course :)
There was a problem hiding this comment.
You mean for "Debian vs. not"? No particular reason, I suppose we don't support a third package format right now. The hack should disappear completely in a week anyway, though.
There was a problem hiding this comment.
Yeah, as the condition is there just to avoid breaking debian. But fair enough since it is rather tmp thing :)
marusak
approved these changes
Aug 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids running into the API breakage of 2.0.3:
containers/podman#7078