Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Packit: notify @containers/packit-build team on failed tasks #1314

Merged
merged 2 commits into from
Sep 26, 2023
Merged

Packit: notify @containers/packit-build team on failed tasks #1314

merged 2 commits into from
Sep 26, 2023

Conversation

lsm5
Copy link
Member

@lsm5 lsm5 commented Sep 26, 2023

No description provided.

@packit-as-a-service
Copy link

Ephemeral COPR build failed. @containers/packit-build please check.

@lsm5 lsm5 marked this pull request as draft September 26, 2023 13:30
@lsm5 lsm5 force-pushed the fix-rpm-add-notification branch from ca879e6 to a164f60 Compare September 26, 2023 13:32
@lsm5 lsm5 marked this pull request as ready for review September 26, 2023 13:51
@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

@giuseppe @flouthoc @rhatdan PTAL

giuseppe
giuseppe approved these changes Sep 26, 2023
View reviewed changes
Copy link
Member

@giuseppe giuseppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, otherwise LGTM

rpm/crun.spec Show resolved Hide resolved
@lsm5 lsm5 force-pushed the fix-rpm-add-notification branch from a164f60 to d86215f Compare September 26, 2023 14:19
@lsm5
rpm: fix manpage installation
0cabf0c 
Also, do not install krun manpage if krun not supported.

Signed-off-by: Lokesh Mandvekar <[email protected]>
@lsm5 lsm5 force-pushed the fix-rpm-add-notification branch from d86215f to 0cabf0c Compare September 26, 2023 14:20
@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

@giuseppe would you be ok with having krun.1 installed only if we have an ENABLE_KRUN or something? I think it would be better than the current patch to remove the manpage.

I can probably create a separate PR for that later.

@giuseppe
Copy link
Member

giuseppe commented Sep 26, 2023 •
edited
Loading

@giuseppe would you be ok with having krun.1 installed only if we have an ENABLE_KRUN or something? I think it would be better than the current patch to remove the manpage.

I can probably create a separate PR for that later.

yes that would be better, I am working on some cleanup and I've already a patch: #1312

Feel free to cherry-pick build: install krun.1 only if krun is enabled and move to this PR, because the remaining things are still WIP

@giuseppe
Copy link
Member

or I can more easily apply it later and drop the line where you rm krun. if you agree

@lsm5
Copy link
Member Author

lsm5 commented Sep 26, 2023

or I can more easily apply it later and drop the line where you rm krun. if you agree

yes this is a much smoother option.

@giuseppe giuseppe merged commit 2079c34 into containers:main Sep 26, 2023
@giuseppe giuseppe mentioned this pull request Sep 27, 2023
Closed
@lsm5 lsm5 deleted the fix-rpm-add-notification branch September 27, 2023 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giuseppe giuseppe giuseppe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lsm5 @giuseppe