Add man page for krun #1297
Add man page for krun #1297
Conversation
|
LGTM, for info: |
|
LGTM, could you please commit also the krun.1 file so we don't need the goo toolchain in the CI (for |
krun.1
Outdated
| containers that follow the Open Container Initiative (OCI) format. | ||
|
|
||
| .PP | ||
| krun uses the dynamic libkrun library to run processes in isolated environment |
There was a problem hiding this comment.
| krun uses the dynamic libkrun library to run processes in isolated environment | |
| krun uses the dynamic libkrun library to run processes in an isolated environment |
krun.1
Outdated
| using KVM Virtualization. | ||
|
|
||
| .PP | ||
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of an |
There was a problem hiding this comment.
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of an | |
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of a |
krun.1
Outdated
|
|
||
| .PP | ||
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of an | ||
| Hypervisor) with the minimum amount of emulated devices required to its purpose, |
There was a problem hiding this comment.
| Hypervisor) with the minimum amount of emulated devices required to its purpose, | |
| Hypervisor) with the minimum amount of emulated devices required for its purpose, |
krun.1
Outdated
| .PP | ||
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of an | ||
| Hypervisor) with the minimum amount of emulated devices required to its purpose, | ||
| abstracting most of the complexity that comes from Virtual Machine management. |
There was a problem hiding this comment.
Soft suggestion: drop "that comes"
| libkrun integrates a VMM (Virtual Machine Monitor, the userspace side of an | ||
| Hypervisor) with the minimum amount of emulated devices required to its purpose, | ||
| abstracting most of the complexity that comes from Virtual Machine management. | ||
|
|
There was a problem hiding this comment.
Ditto comments from above in this file
|
Should we somehow clarify this isn't an independent OCI runtime but a way to tell crun to enable the libkrun plugin? |
rhatdan
force-pushed
the
man
branch
2 times, most recently
from
d6ac519 to
faf7324
Compare
|
@TomSweeneyRedHat @slp Version 2 now available for review. |
|
@giuseppe I think this is ready to in. @slp @TomSweeneyRedHat one last look? |
krun.1.md
Outdated
| command is a symbolic link to the crun execuable, that tells crun to run in | ||
| krun mode. | ||
|
|
||
| krun uses the dynamic libkrun library to run processes in isolated environment |
There was a problem hiding this comment.
need "an" between "in and "isolated" here and above.
|
One tweak, otherwise LGTM |
krun.1
Outdated
|
|
||
| .PP | ||
| Because of the additional isolation, sharing content with processes and other | ||
| containres outside of the krun VM is more difficult. |
There was a problem hiding this comment.
| containres outside of the krun VM is more difficult. | |
| containers outside of the krun VM is more difficult. |
krun.1
Outdated
| .PP | ||
| krun is a sub package of the crun command line program for running Linux | ||
| containers that follow the Open Container Initiative (OCI) format. The krun | ||
| command is a symbolic link to the crun execuable, that tells crun to run in |
There was a problem hiding this comment.
| command is a symbolic link to the crun execuable, that tells crun to run in | |
| command is a symbolic link to the crun executable, that tells crun to run in |
Signed-off-by: Daniel J Walsh <[email protected]>
|
LGTM! |
No description provided.