Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg/netns: some netns improvements #2168

Merged
merged 4 commits into from
Sep 20, 2024
Merged

pkg/netns: some netns improvements #2168

merged 4 commits into from
Sep 20, 2024

Commits on Sep 20, 2024

  1. pkg/netns: split out makeNetnsDir logic 

    Create a new function to create the netns dir.

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    1f1ecfa View commit details
    Browse the repository at this point in the history

  2. pkg/netns: ensure makeNetnsDir is race free 

    There are some rather bad problems when we bind mount over multiple
times, this is a rather small race but can happen. In order to avoid
this take an exclusive lock like ip netns add does because they create
the same bind mount setup. As such we will not race against other podman
process or ip netns add which is a good thing.

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    a498d92 View commit details
    Browse the repository at this point in the history

  3. pkg/netns: add NewNSFrom() 

    The new API should replace the logic from Podman's setupNetNS() which
did several things incorrect. First and foremost it never bind mounted
the netns dir causing problems when the netns dir was later bind mounted
duplicating the netns mounts on diffeent parents which then caused all
unmount attempts to fail[1].

Also the Podman code did never check for conlicts so we way end up
overwriting an existing netns (super unlikely as we use 16 random bytes
but still). At the very least it duplicates the name logic for no reason
there so having this all here makes much more sense.

Of course we still have to port podman over to this new API.

[1] https://issues.redhat.com/browse/RHEL-59620

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    ab7136b View commit details
    Browse the repository at this point in the history

  4. pkg/netns: remove NewNSWithName() 

    This API is not used anywhere, as such remove it and make the loop in
NewNS() better as the netns dir parts should not be part of the loop.

Signed-off-by: Paul Holzinger <[email protected]>
    @Luap99
    Luap99 committed Sep 20, 2024
    Configuration menu
    Copy the full SHA
    82b485b View commit details
    Browse the repository at this point in the history