pkg/netns: some netns improvements #2168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Create a new function to create the netns dir. Signed-off-by: Paul Holzinger <[email protected]>
There are some rather bad problems when we bind mount over multiple times, this is a rather small race but can happen. In order to avoid this take an exclusive lock like ip netns add does because they create the same bind mount setup. As such we will not race against other podman process or ip netns add which is a good thing. Signed-off-by: Paul Holzinger <[email protected]>
The new API should replace the logic from Podman's setupNetNS() which did several things incorrect. First and foremost it never bind mounted the netns dir causing problems when the netns dir was later bind mounted duplicating the netns mounts on diffeent parents which then caused all unmount attempts to fail[1]. Also the Podman code did never check for conlicts so we way end up overwriting an existing netns (super unlikely as we use 16 random bytes but still). At the very least it duplicates the name logic for no reason there so having this all here makes much more sense. Of course we still have to port podman over to this new API. [1] https://issues.redhat.com/browse/RHEL-59620 Signed-off-by: Paul Holzinger <[email protected]>
This API is not used anywhere, as such remove it and make the loop in NewNS() better as the netns dir parts should not be part of the loop. Signed-off-by: Paul Holzinger <[email protected]>
|
We were not able to find or create Copr project Unless the HTTP status code above is >= 500, please check your configuration for:
|
|
@giuseppe PTAL |
Luap99
changed the title
|
Podman PR: containers/podman#24024 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: giuseppe, Luap99 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see commits, marking as draft until I ported in podman and passed CI there