libcni: add InitCNIConfigWithCacheDir() and deprecate RuntimeConfig.CacheDir #682
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mars1024
reviewed
Jun 20, 2019
…acheDir CacheDir is a property of the entire CNIConfig object and there is no point to having it be different between container invocations. It was originally put in RuntimeConfig to make re-vendoring easier so that users wouldn't have to update calls to InitCNIConfig.
This was referenced Jun 26, 2019
Luap99
pushed a commit
to Luap99/ocicni
that referenced
this pull request
Feb 18, 2021
Add a new function InitCNIWithCache which works like InitCNI except that it accepts an extra parameter to set the cache directory. This change is needed for rootless users which are trying to use cni in a user+net namespace because the default directory is not writeable by rootless users. Second, setting the cni cache directory via the runtime config is deprecated. It has to be set with NewCNIConfigWithCacheDir for the cni config. see: containernetworking/cni#682 Signed-off-by: Paul Holzinger <[email protected]>
Luap99
pushed a commit
to Luap99/ocicni
that referenced
this pull request
Feb 18, 2021
Add a new function InitCNIWithCache which works like InitCNI except that it accepts an extra parameter to set the cache directory. This change is needed for rootless users which are trying to use cni in a user+net namespace because the default directory is not writeable by rootless users. Second, setting the cni cache directory via the runtime config is deprecated. It has to be set with NewCNIConfigWithCacheDir for the cni config. see: containernetworking/cni#682 Signed-off-by: Paul Holzinger <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CacheDir is a property of the entire CNIConfig object and there is no
point to having it be different between container invocations. It was
originally put in RuntimeConfig to make re-vendoring easier so that
users wouldn't have to update calls to InitCNIConfig.
@containernetworking/cni-maintainers