You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Yes, I also agree on that runtime should not change cache dir freely.
So maybe there is another way, we can put cache dir from runtimeConfig to CNIConfig, and add a new constructor func NewCNIConfig(path []string, exec invoke.Exec, cacheDir string) *CNIConfig, if we use the old constructor NewCNIConfig(path []string, exec invoke.Exec) *CNIConfig, the cache dir will be a default value. Once cache dir is set in CNIConfig, it won't be changed by any CNI user.
Yes, I also agree on that runtime should not change cache dir freely.
So maybe there is another way, we can put cache dir from runtimeConfig to CNIConfig, and add a new constructor
func NewCNIConfig(path []string, exec invoke.Exec, cacheDir string) *CNIConfig
, if we use the old constructorNewCNIConfig(path []string, exec invoke.Exec) *CNIConfig
, the cache dir will be a default value. Once cache dir is set in CNIConfig, it won't be changed by any CNI user.Originally posted by @mars1024 in #678
The text was updated successfully, but these errors were encountered: