Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move cache dir from runtimeConfig to CNIConfig #683

Closed
mars1024 opened this issue Jun 20, 2019 · 1 comment
Closed

move cache dir from runtimeConfig to CNIConfig #683

mars1024 opened this issue Jun 20, 2019 · 1 comment

Comments

@mars1024
Copy link
Member

Yes, I also agree on that runtime should not change cache dir freely.
So maybe there is another way, we can put cache dir from runtimeConfig to CNIConfig, and add a new constructor func NewCNIConfig(path []string, exec invoke.Exec, cacheDir string) *CNIConfig, if we use the old constructor NewCNIConfig(path []string, exec invoke.Exec) *CNIConfig, the cache dir will be a default value. Once cache dir is set in CNIConfig, it won't be changed by any CNI user.

Originally posted by @mars1024 in #678

@mars1024
Copy link
Member Author

close via #682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant