Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nerdctl run: reset the default value of limits. #2682

Merged
merged 1 commit into from
Dec 9, 2023

Commits on Dec 5, 2023

  1. nerdctl run: reset the default value of limits.

    With the oci spec, we have the default rlimits RLIMIT_NOFILE=1024:1024,
    If we start a pod in kubelet, this value we be reset to nil by cri.
    We use the nerdctl to start containers in production, this difference
    will cause user confused.
    
    When run a container if don't get any ulimit opts, reset the rlimits
    to nil. This will remove the default 1024 file limit.
    ```go
    if len(ulimitOpts) == 0 {
    	ulimitOpts = append(ulimitOpts, withRlimits(nil))
    }
    ```
    
    Warning: this PR will make `nerdctl run` behave differently than before.
    Signed-off-by: Zoe <[email protected]>
    jiusanzhou committed Dec 5, 2023
    Configuration menu
    Copy the full SHA
    06628f6 View commit details
    Browse the repository at this point in the history