nerdctl run: reset the default value of limits. #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the oci spec, we have the default rlimits RLIMIT_NOFILE=1024:1024,
If we start a pod in kubelet, this value we be reset to nil by cri.
We use the nerdctl to start containers in production, this difference
will cause user confused.
When run a container if don't get any ulimit opts, reset the rlimits
to nil. This will remove the default 1024 file limit.
```go
if len(ulimitOpts) == 0 {
ulimitOpts = append(ulimitOpts, withRlimits(nil))
}
```
Warning: this PR will make `nerdctl run` behave differently than before.
Signed-off-by: Zoe <[email protected]>
yankay
approved these changes
Dec 6, 2023
There was a problem hiding this comment.
Thanks @jiusanzhou
I've invesgated, the behavior is also compatible Docker.
|
Can we have a test? |
AkihiroSuda
approved these changes
Dec 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the oci spec, we have the default rlimits RLIMIT_NOFILE=1024:1024, If we start a pod in kubelet, this value we be reset to nil by cri. We use the nerdctl to start containers in production, this difference will cause user confused.
When run a container if don't get any ulimit opts, reset the rlimits to nil. This will remove the default 1024 file limit.
Warning: this PR will make
nerdctl runbehave differently than before.