This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Erase ambient capabilities. #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lantao Liu <[email protected]>
mikebrow
reviewed
Jun 11, 2018
| // is not clearly defined in Kubernetes. | ||
| // See https://github.com/kubernetes/kubernetes/issues/56374 | ||
| // Keep docker's behavior for now. | ||
| g.Spec().Process.Capabilities.Ambient = []string{} |
There was a problem hiding this comment.
If there are ambient caps, let's log that ambient caps are not supported for containers in Kubernetes pods, but that the container will be created with the ambient caps masked.
There was a problem hiding this comment.
There is no ambient cap in CRI, these are all containerd implementation details.
Don't think we need to log it. :)
|
Will fix the presubmit test. We should not use K8s HEAD to test old release branch. |
|
/test pull-cri-containerd-node-e2e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick #808.
Signed-off-by: Lantao Liu [email protected]