This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Erase ambient capabilities. #808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do you want this in 1.1.1? It is a behavior change, but are you more concerned with being consistent with Docker or 1.1.0? I don't quite understand how such a change might affect users though, is this a commonly used feature which anyone would be relying on if we changed it in 1.1.1... |
|
@dmcgowan Will cherry-pick. :) We'll maintain 1.1.x for a long time, let's make sure it is working correctly. |
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
erase-ambient-caps
branch
from
b1fee9e
to
b367f30
Compare
|
/test pull-cri-containerd-node-e2e |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not a huge problem to
containerd/cri, because our default ambient list is empty. https://github.com/containerd/containerd/blob/master/oci/spec_unix.go#L97However, we add ambient cap if user explicitly adds it. This is not a CVE, but a behavior change to me. We decided to follow docker's behavior for backward compatibility. And we can carry on discussion about how to better handle this in kubernetes/kubernetes#56374.
Signed-off-by: Lantao Liu [email protected]