This repository has been archived by the owner on Mar 9, 2022. It is now read-only.
Support shared pid #603
Merged
Support shared pid #603
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Random-Liu
force-pushed
the
support-shared-pid
branch
from
4419e9b to
61744f2
Compare
Random-Liu
force-pushed
the
support-shared-pid
branch
from
61744f2 to
66d158b
Compare
Random-Liu
force-pushed
the
support-shared-pid
branch
from
66d158b to
e665aed
Compare
yujuhong
reviewed
Feb 8, 2018
| g.RemoveLinuxNamespace(string(runtimespec.PIDNamespace)) // nolint: errcheck | ||
| // Do not share pid namespace if namespace mode is CONTAINER. | ||
| if namespaces.GetPid() != runtime.NamespaceMode_CONTAINER { | ||
| g.AddOrReplaceLinuxNamespace(string(runtimespec.PIDNamespace), getPIDNamespace(sandboxPid)) // nolint: errcheck |
There was a problem hiding this comment.
What happened to the host pid mode?
There was a problem hiding this comment.
Also share with sandbox.
pkg/server/sandbox_status_test.go
Outdated
| HostNetwork: true, | ||
| HostPid: false, | ||
| HostIpc: true, | ||
| Network: runtime.NamespaceMode_POD, |
There was a problem hiding this comment.
Why changing the host network setting in the test?
There was a problem hiding this comment.
The test is to test the convert function toCRISandboxStatus. It's just simply conversion. I just want to make sure all modes are covered. :)
I can keep network NODE.
Random-Liu
force-pushed
the
support-shared-pid
branch
from
e665aed to
b16c4f2
Compare
|
/lgtm |
|
@yujuhong Thanks for reviewing! Will merge after test passes to unblock the presubmit test. Currently all e2e/node e2e tests are failing. |
|
This depends on kubernetes-sigs/cri-tools#238. |
Merged
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
support-shared-pid
branch
from
b16c4f2 to
08f52ba
Compare
Signed-off-by: Lantao Liu <[email protected]>
Signed-off-by: Lantao Liu <[email protected]>
Random-Liu
force-pushed
the
support-shared-pid
branch
from
08f52ba to
532a895
Compare
mikebrow
approved these changes
Feb 8, 2018
| @@ -7,7 +7,7 @@ | |||
| [](https://travis-ci.org/containerd/cri-containerd) | |||
| [](https://goreportcard.com/report/github.com/containerd/cri-containerd) | |||
|
|
|||
| `cri-containerd` is a [containerd](https://containerd.io/) based implementation of Kubernetes [container runtime interface (CRI)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/v1alpha1/runtime/api.proto). | |||
| `cri-containerd` is a [containerd](https://containerd.io/) based implementation of Kubernetes [container runtime interface (CRI)](https://github.com/kubernetes/kubernetes/blob/master/pkg/kubelet/apis/cri/runtime/v1alpha2/api.proto). | |||
There was a problem hiding this comment.
Ok.. I realize you have no choice here.. but what was the point of them moving the version to the suffix of runtime instead of the prefix. It just feels wrong.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #597.
All cri-containerd e2e/node-e2e tests are failing because of the breaking CRI change.
Let's get this in sooner.
/cc @yujuhong @mikebrow @verb