Skip to content
This repository has been archived by the owner on Mar 9, 2022. It is now read-only.

update critools #602

Merged
merged 2 commits into from
Feb 8, 2018
Merged

update critools #602

merged 2 commits into from
Feb 8, 2018

Conversation

mikebrow
Copy link
Member

@mikebrow mikebrow commented Feb 7, 2018 •
edited
Loading

commit 1: Updates to the latest critools. Uses new critools make install-crictl.
commit 2: change crictl sandboxes to pods; other references to sandboxes

Signed-off-by: Mike Brown [email protected]

@mikebrow
update critools
f19cd8a 
Signed-off-by: Mike Brown <[email protected]>
@Random-Liu
Copy link
Member

@mikebrow You also need to update all crictl sandboxes. It is changed to crictl pods.

@Random-Liu Random-Liu self-assigned this Feb 7, 2018
@Random-Liu
Copy link
Member

Fixes #534.

@Random-Liu Random-Liu added this to the v1.0.0-rc.0 milestone Feb 7, 2018
@mikebrow
Copy link
Member Author

mikebrow commented Feb 7, 2018

You also need to update all crictl sandboxes. It is changed to crictl pods.

Thx will adding a commit for that, was skimming over the prs in cri-tools and got interrupted forgot to finish my skim checking for changes :-)

@k8s-ci-robot
Copy link

@mikebrow: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-cri-containerd-node-e2e edb2b23 link /test pull-cri-containerd-node-e2e

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Random-Liu
Random-Liu reviewed Feb 8, 2018
View reviewed changes
docs/crictl.md
$ crictl sandboxes
SANDBOX ID CREATED STATE NAME NAMESPACE ATTEMPT
$ crictl pods
PODSANDBOX ID CREATED STATE NAME NAMESPACE ATTEMPT
e1c83b0b8d481 2 hours ago SANDBOX_READY nginx-sandbox default 1
$ crictl inspects e1c8
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/inspects/inspectp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #603

hack/cri-reset.sh
crictl_stop_sandboxes() {
for x in $($CRICTL_CLI sandboxes | awk '{ print $1 }' | awk '{if(NR>1)print}') ;do
crictl_stop_pods() {
for x in $($CRICTL_CLI pods | awk '{ print $1 }' | awk '{if(NR>1)print}') ;do
$CRICTL_CLI stops $x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stopp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #603

hack/cri-reset.sh
crictl_rm_sandboxes() {
for x in $($CRICTL_CLI sandboxes | awk '{ print $1 }' | awk '{if(NR>1)print}') ;do
crictl_rm_pods() {
for x in $($CRICTL_CLI pods | awk '{ print $1 }' | awk '{if(NR>1)print}') ;do
$CRICTL_CLI rms $x
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rmp

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done in #603

@Random-Liu
Copy link
Member

LGTM with nits

@Random-Liu
Copy link
Member

Random-Liu commented Feb 8, 2018 •
edited
Loading

Merge this PR directly. I'll address comments in a commit in #603.

Just try to make the test back to green as fast as possible. :)

@Random-Liu Random-Liu merged commit 047df7a into containerd:master Feb 8, 2018
@Random-Liu Random-Liu mentioned this pull request Feb 8, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Random-Liu Random-Liu Random-Liu left review comments

Assignees

@Random-Liu Random-Liu

Labels
size/M
Projects
None yet
Milestone
v1.0.0-rc.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mikebrow @Random-Liu @k8s-ci-robot