Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Integrate diamond #266

Merged
merged 19 commits into from
Jul 27, 2023
Merged

Integrate diamond #266

merged 19 commits into from
Jul 27, 2023

Conversation

cryptoAtwill
Copy link
Contributor

@cryptoAtwill cryptoAtwill commented Jul 26, 2023

Integrate with solidity diamond pattern, some key changes:

  • Removed gateway and subnet actor abi and replaced with diamond abi
  • Updated conversion module that uses macro rules to generate types so that code duplication is minimized.
    This PR relies on Diamond patches ipc-solidity-actors#158 to provide full getter functions.

@cryptoAtwill cryptoAtwill changed the base branch from main to dev July 26, 2023 04:21
@adlrocha adlrocha self-requested a review July 26, 2023 06:49
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! LGTM.

@adlrocha adlrocha merged commit 8122281 into dev Jul 27, 2023
@adlrocha adlrocha deleted the integrate_diamond branch July 27, 2023 18:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants