Skip to content
This repository has been archived by the owner on Jan 11, 2024. It is now read-only.

Implement list subnet #267

Merged
merged 8 commits into from
Jul 27, 2023
Merged

Implement list subnet #267

merged 8 commits into from
Jul 27, 2023

Conversation

cryptoAtwill
Copy link
Contributor

@cryptoAtwill cryptoAtwill commented Jul 27, 2023

Implement list subnet for solidity contracts. Key changes:

  • Removed serialization module and migrated code to NativeBottomUpCheckpoint
  • Added corresponding contract call
  • Updated interface to use NativeBottomUpCheckpoint and updated different type conversions.
  • Introduced bottom_up_checkpoint macro rules to handle different solidity contract generated module type conversion

@cryptoAtwill cryptoAtwill requested a review from adlrocha July 27, 2023 07:19
Copy link
Contributor

@adlrocha adlrocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -180,3 +184,132 @@ impl<P: BottomUpHandler, C: BottomUpHandler> CheckpointManager for BottomUpManag
Ok(true)
}
}

// Serialization related
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of a curiosity, why are these needed?

@adlrocha adlrocha merged commit 70bb43f into integrate_diamond Jul 27, 2023
@adlrocha adlrocha deleted the list_subnets branch July 27, 2023 18:18
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants