Fix gRPC-Web trailers-only response handling for server-streaming RPCs #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
Signed-off-by: Timo Stamm <[email protected]>
srikrsna-buf
approved these changes
Oct 9, 2024
timostamm
deleted the
tstamm/fix-grpc-web-client-server-streaming-trailers-only
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gRPC-Web supports "trailers-only" responses - error responses with an empty body, that have all trailer fields in the response headers.
The gRPC-Web transport from
@connectrpc/connect-webhas a bug handling these responses: It raises an error as expected for unary RPCs, but it does not raise an error for server-streaming RPCs.The next release of the conformance test suite will include tests for this case (added in connectrpc/conformance#935).