Expand test cases for gRPC-Web Trailers to servers-streaming RPCs #935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Timo Stamm <[email protected]>
timostamm
force-pushed
the
Expand-test-cases-for-gRPC-Web-Trailers-to-servers-streaming-RPCs
branch
from
12271fa
to
e07dfcb
Compare
jhump
reviewed
Oct 8, 2024
|
|
||
| # Server-streaming: Trailers and status are in body (no other response messages) | ||
| - request: | ||
| testName: server-stream/trailers-in-body/expected |
There was a problem hiding this comment.
For increased clarity of test case names (and more consistency/uniformity), could you rename the existing ones to have a "unary/" prefix?
There was a problem hiding this comment.
Are we okay with potentially breaking known-failing lists?
There was a problem hiding this comment.
There was a problem hiding this comment.
Excellent. Done in 911c055.
Signed-off-by: Timo Stamm <[email protected]>
jhump
approved these changes
Oct 8, 2024
timostamm
deleted the
Expand-test-cases-for-gRPC-Web-Trailers-to-servers-streaming-RPCs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We noticed a bug in the gRPC-Web transport from
@connectrpc/connect-web, where a trailers-only response for a server-streaming RPC failed to raise an error as expected.I think it makes sense to expand the test cases to cover server-streaming in addition to unary.