-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add a DefaultSchemaRegistryClient and remove default for SR url in KsqlConfig #4325
Conversation
ksql-engine/src/main/java/io/confluent/ksql/schema/registry/DefaultSchemaRegistryClient.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. One comment inline.
...-engine/src/main/java/io/confluent/ksql/schema/registry/KsqlSchemaRegistryClientFactory.java
Show resolved
Hide resolved
5e33a1a
to
847ee27
Compare
Reworked the error message to be pluggable with the |
ad2cc75
to
fa47b9f
Compare
While reworking this to have the pluggable error message, it seems like it might be better to move the config from KsqlRestConfig to KsqlConfig, thoughts @rodesai @spena ? Also, tagging @big-andy-coates since he was reviewer of original PR adding the config.
|
fa47b9f
to
f9ab7b1
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sorry I'm late to the party, but this is a breaking change, right? If I understand correctly, previously users didn't need to explicitly set a config for KSQL to pick up a Schema Registry cluster at
|
This change broke
My preference would be the latter since it keeps the usage of the |
Description
Fixes #4319
Removed default URL for SR from KsqlConfig
Implemented a new
DefaultSchemaRegistryClient
that's used when the URL is""
Testing done
Unit test
Verified logs weren't being spammed when closing queries
Reviewer checklist