explicitly set ksql.schema.registry.url in the server properties file when local start for the ksql-server #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when local start for the ksql-server
|
(Note, make sure all CI passes first -- you may need to just re-run some of the tests, CI can be flaky occasionally) |
codyaray
reviewed
Feb 3, 2020
| config_service "ksql-server" "ksql" "ksql-server"\ | ||
| "kafkastore.connection.url" "localhost:${zk_port}" | ||
| echo "ksql.schema.registry.url=http://localhost:${schema_registry_port}" \ |
There was a problem hiding this comment.
shouldn't this use config_service helper that everything seems to have standardized on?
There was a problem hiding this comment.
I was trying to follow what config_kafka-rest() was doing originally, but the config didn't seem to be getting picked up by the ksql server
There was a problem hiding this comment.
I did a test with config_service and directly injecting the config, and looked at the resulting message when trying to connect to SR from KSQL. (3333 is a random port)
echo "ksql.schema.registry.url=http://localhost:3333" \
"${service_dir}/${service}.properties"
Schema registry fetch for topic test request failed.
Caused by: Could not connect to the server.
This is what the behavior should be ^
config_service "ksql-server" "ksql" "ksql-server"\
"ksql.schema.registry.url" "http://localhost:3333" "reapply"
Avro schema for message values on topic test does not exist in the Schema Registry.Subject: test-value
This indicates that the config wasn't successfully set
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
confluentinc/ksql#4325
Removed the default SR url so now it has to be set in the KSQL server configs. The given server properties file shouldn't have the config specified by default since KSQL can run without Schema Registry configured.
Using the local command requires KSQL to be configured with Schema Registry so it needs to be appended to the server properties file when starting up
References
https://confluentinc.atlassian.net/browse/KSQL-4034
Test&Review