140/channels filter by connection #153
Conversation
bartmacbartek
force-pushed
the
140/channels-filter-by-connection
branch
from
26805c1
to
78f1771
Compare
bartmacbartek
force-pushed
the
140/channels-filter-by-connection
branch
from
78f1771
to
4c58c87
Compare
| 'transfer', | ||
| 'custom', | ||
| Order.ORDER_UNORDERED, | ||
| 'ics20-1' |
There was a problem hiding this comment.
Are these values not available from test utils?
There was a problem hiding this comment.
I didn't know but there's something. I had to flip things up but it works: c47a936
|
|
||
| fsReadFileSync.returns(registryYaml); | ||
|
|
||
| await run(options, (logger as unknown) as Logger); |
There was a problem hiding this comment.
Hm, maybe we should unify the Logger types in lib and binary.
There was a problem hiding this comment.
Yes, I already spotted this here: #149 (comment)
Created a task: #155
| .find((value) => | ||
| value.match( | ||
| new RegExp( | ||
| `[^\\s]+\\s+(?!${options.port})[^\\s]+\\s+[^\\s]+\\s+[^\\s]+` |
There was a problem hiding this comment.
This is a little hard to understand and seems easy to make a mistake and get false negatives here. How about checking that every channel has the correct port?
There was a problem hiding this comment.
You're right. I inverted it and also spotted an edge case with last empty line.
I think it's easier to follow now, see: 281a400
Closes #140