Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify test logger for lib and binary #155

Open
bartmacbartek opened this issue Apr 13, 2021 · 2 comments
Open

Unify test logger for lib and binary #155

bartmacbartek opened this issue Apr 13, 2021 · 2 comments
Labels
Binary Code for the actual executable enhancement New feature or request Library Functionality in the core library

Comments

@bartmacbartek
Copy link
Contributor

Context:

Move TestLogger out of lib and unify its interface so it can be used in binary tests without unsafe typecasting: https://github.com/confio/ts-relayer/blob/main/src/binary/ibc-setup/commands/connections.spec.ts#L60
@bartmacbartek bartmacbartek added enhancement New feature or request Library Functionality in the core library Binary Code for the actual executable labels Apr 13, 2021
@bartmacbartek bartmacbartek mentioned this issue Apr 13, 2021
Merged
@ethanfrey
Copy link
Contributor

Good idea

@ethanfrey
Copy link
Contributor

Just make sure this doesn't pull in any node-only deps into the lib, but it would definitely be helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Binary Code for the actual executable enhancement New feature or request Library Functionality in the core library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ethanfrey @bartmacbartek