Kata agent config cleanup #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just an update on this - there is something wrong with the server address not flowing through: which explains the comment that was added in the agent-config.toml. I will try and debug it to see if I can work out the cause... |
|
Ok, I think there is a bug in the kata config processing, so I'll try and fix that up and then re-test this. |
|
FYI: kata-containers/kata-containers#9819 is my attempt to fix and let envs being processed with the config file |
stevenhorsman
force-pushed
the
kata-agent-config-cleanup
branch
4 times, most recently
from
04d62ea to
657cc9f
Compare
- In kata-containers/kata-containers#8229 the code that read the endpoint restrictions using the agent config was removed in favour of policy, so these don't have any effect now. Signed-off-by: stevenhorsman <[email protected]>
- We haven't ported signature verification across to the main branch of kata-containers yet, so remove this config until it's needed Signed-off-by: stevenhorsman <[email protected]>
- After discussion in the community meeting the suggestion was to keep the server address specified in the agent-config file permanently, so tidy up the comments about using the env instead to set it Signed-off-by: stevenhorsman <[email protected]>
stevenhorsman
force-pushed
the
kata-agent-config-cleanup
branch
from
657cc9f to
9d891f7
Compare
mkulke
approved these changes
Jun 14, 2024
huoqifeng
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
LGTM
Glad to see endpoints get removed, thanks! @stevenhorsman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.