Skip to content

Commit

Permalink
podvm: config: clean up server address comments
Browse files Browse the repository at this point in the history
- After discussion in the community meeting the suggestion was
to keep the server address specified in the agent-config file
permanently, so tidy up the comments about using the env instead
to set it

Signed-off-by: stevenhorsman <[email protected]>
  • Loading branch information
stevenhorsman committed Jun 12, 2024
1 parent 152de01 commit 04d62ea
Show file tree
Hide file tree
Showing 4 changed files with 0 additions and 4 deletions.
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# When using the agent-config.toml the KATA_AGENT_SERVER_ADDR env var seems to be ignored, so set it here
server_addr = "unix:///run/kata-containers/agent.sock"

# This field sets up the KBC that attestation agent uses
Expand Down
1 change: 0 additions & 1 deletion src/cloud-api-adaptor/pkg/agent/update_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ func TestUpdateAAKBCParams(t *testing.T) {

// Write a sample agent config data to the file
testAgentConfigData := `
# When using the agent-config.toml the KATA_AGENT_SERVER_ADDR env var seems to be ignored, so set it here
server_addr="unix:///run/kata-containers/agent.sock"
# This field sets up the KBC that attestation agent uses
Expand Down
1 change: 0 additions & 1 deletion src/cloud-api-adaptor/podvm/files/etc/agent-config.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
# When using the agent-config.toml the KATA_AGENT_SERVER_ADDR env var seems to be ignored, so set it here
server_addr = "unix:///run/kata-containers/agent.sock"

# This field sets up the KBC that attestation agent uses
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ ExecStartPre=mkdir -p /run/kata-containers
ExecStart=/usr/local/bin/kata-agent --config /etc/agent-config.toml
ExecStartPre=-umount /sys/fs/cgroup/misc
ExecStopPost=/usr/local/bin/kata-agent-clean --config /etc/agent-config.toml
# Now specified in the agent-config.toml Environment="KATA_AGENT_SERVER_ADDR=unix:///run/kata-containers/agent.sock"
SyslogIdentifier=kata-agent

[Install]
Expand Down

0 comments on commit 04d62ea

Please sign in to comment.