Azure: Use versions.yaml to read go version in e2e test #1509
Conversation
.github/workflows/azure-e2e-test.yml
Outdated
| run: | | ||
| go_version="$(yq '.tools.golang' versions.yaml)" | ||
| [ -n "$go_version" ] | ||
| echo "GO_VERSION=${go_version}" >> "$GITHUB_ENV" |
There was a problem hiding this comment.
Has this been tested? I think the env is just set for this job (read-properties), we need to use outputs if we want to carry variables from job to job, but why not just embed this in the build job?
There was a problem hiding this comment.
Actually this version is being used at multiple places it will be better to use output rather than reading file multiple times.
There was a problem hiding this comment.
I don't know, that just adds more ceremony. I think the above version extraction can be condensed into a one liner and then it'll be just 2 lines per job (note the -e flag, that will make the job fail if unset)
- name: Extract go version number
run: echo "GO_VERSION=$(yq -e '.tools.golang' versions.yaml)" >> "$GITHUB_ENV"
kartikjoshi21
force-pushed
the
kartikjoshi21/versions-e2e-test
branch
2 times, most recently
from
7681c41 to
789ffb8
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/versions-e2e-test
branch
2 times, most recently
from
c121870 to
13f4b0a
Compare
kartikjoshi21
force-pushed
the
kartikjoshi21/versions-e2e-test
branch
from
13f4b0a to
ef038c8
Compare
|
The rebase introduced two new places in the file where we need to use the versions.yaml instead of the hard-coded string. Could you please update these, too? |
Use versions.yaml to read go version in e2e test Fixes: confidential-containers#1496 Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21
force-pushed
the
kartikjoshi21/versions-e2e-test
branch
from
ef038c8 to
3cfdec6
Compare
Use versions.yaml to read go version in e2e test
Fixes: #1496