Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Azure-e2e-test: Use the go version from versions.yaml file #1496

Closed
surajssd opened this issue Oct 4, 2023 · 0 comments · Fixed by #1509
Closed

Azure-e2e-test: Use the go version from versions.yaml file #1496

surajssd opened this issue Oct 4, 2023 · 0 comments · Fixed by #1509
Assignees
@kartikjoshi21
Labels
CI Issues related to CI workflows e2e-test provider/azure Issues related to Azure CAA provider

Comments

@surajssd
Copy link
Member

surajssd commented Oct 4, 2023

Right now, we hard-code the Golang version instead of referring it from the versions.yaml file.

cloud-api-adaptor/.github/workflows/azure-e2e-test.yml

Line 54 in cc34a12

go-version: '1.20'

cloud-api-adaptor/.github/workflows/azure-e2e-test.yml

Line 99 in cc34a12

go-version: '1.20'

@surajssd surajssd added CI Issues related to CI workflows provider/azure Issues related to Azure CAA provider e2e-test labels Oct 4, 2023
@kartikjoshi21 kartikjoshi21 self-assigned this Oct 10, 2023
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
9ca0799 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
24cca0e 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
b78055d 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
849abe9 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
493c126 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
875da54 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
@kartikjoshi21 kartikjoshi21 mentioned this issue Oct 11, 2023
Merged
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
7681c41 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 11, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
789ffb8 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 12, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
c121870 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 12, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
13f4b0a 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 16, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
ef038c8 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit to kartikjoshi21/cloud-api-adaptor that referenced this issue Oct 25, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
3cfdec6 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
kartikjoshi21 added a commit that referenced this issue Oct 25, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
4f2375b 
Use versions.yaml to read go version in e2e test

Fixes: #1496
Signed-off-by: Kartik Joshi <[email protected]>
sudharshanibm3 pushed a commit to sudharshanibm3/cloud-api-adaptor that referenced this issue Oct 27, 2023
@kartikjoshi21 @sudharshanibm3
Azure: Use versions.yaml to read go version in e2e test
2008e9f 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
lysliu pushed a commit to lysliu/cloud-api-adaptor that referenced this issue Nov 9, 2023
@kartikjoshi21
Azure: Use versions.yaml to read go version in e2e test
7f1b6d7 
Use versions.yaml to read go version in e2e test

Fixes: confidential-containers#1496
Signed-off-by: Kartik Joshi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kartikjoshi21 kartikjoshi21

Labels
CI Issues related to CI workflows e2e-test provider/azure Issues related to Azure CAA provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Azure: Use versions.yaml to read go version in e2e test kartikjoshi21/cloud-api-adaptor
2 participants
@surajssd @kartikjoshi21