refactor!: lock-file API #942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…/source_deps_in_lock
…/source_deps_in_lock
…/source_deps_in_lock
tdejager
approved these changes
Nov 18, 2024
baszalmstra
added a commit
that referenced
this pull request
Nov 18, 2024
* feat: lock file update for source dependencies (#866) Co-authored-by: Bas Zalmstra <[email protected]> Co-authored-by: Bas Zalmstra <[email protected]> * feat: add input hash to conda package * feat: add input hash/glob to lock file (#868) * fix: mark records as changed if hash Option value is different (#874) This adds the case that where the hash changed, which happened for my source build, that a re-install is triggered. I think this is the correct behavior, not sure if it will trigger *too* many re-installs but did not feel that would be the case. * fix: python bindings issues (#872) * fix: normalize channel in lock file (#871) * fix: dead-lock issue * feat: use sha in cache lock file, needed for source builds. (#900) * fix: package hash revalidation (#904) * refactor!: lock-file API (#942) This PR significantly refactors the lock-file API to make the distinction between source and binary conda packages. It also changes the way we handle borrowing data from the lock-file, preferring borrowing over owned objects. The Python bindings have also been completely refactored to be more pythonic. Instead of having a single `LockedPackage` there is no a class hierarchy of `LockedPackage` -> `CondaLockedPackage`, `PypiLockedPackage` -> `CondaLockedSourcePackage` and `CondaLockedBinaryPackage`. --------- Co-authored-by: Tim de Jager <[email protected]> Co-authored-by: Tim de Jager <[email protected]> Co-authored-by: nichmor <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR significantly refactors the lock-file API to make the distinction between source and binary conda packages. It also changes the way we handle borrowing data from the lock-file, preferring borrowing over owned objects.
The Python bindings have also been completely refactored to be more pythonic. Instead of having a single
LockedPackagethere is no a class hierarchy ofLockedPackage->CondaLockedPackage,PypiLockedPackage->CondaLockedSourcePackageandCondaLockedBinaryPackage.