sys.exit removals from build.py
#5402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
conda-bot
added
the
cla-signed
CodSpeed Performance ReportMerging #5402 will not alter performanceComparing Summary
|
beeankha
changed the title
sys.exit removals from features.py, build.pysys.exit removals from features.py, build.py, and cli/main_build.py
kenodegard
requested changes
Jul 11, 2024
beckermr
previously approved these changes
Jul 11, 2024
beeankha
changed the title
sys.exit removals from features.py, build.py, and cli/main_build.pysys.exit removals from build.py
kenodegard
reviewed
Jul 11, 2024
beeankha
added a commit
to beeankha/conda-build
that referenced
this pull request
Jul 11, 2024
beeankha
added a commit
to beeankha/conda-build
that referenced
this pull request
Jul 11, 2024
kenodegard
approved these changes
Jul 12, 2024
beeankha
added a commit
that referenced
this pull request
Jul 15, 2024
* Remove remaining sys.exit calls from build.py * Remove sys.exit call from features.py * Revert cleanup changes in build.py * Remove sys.exit calls from main_build.py, update tests * Revert changes to in order to keep the PR small in scope * Revert changes to in order to keep the PR small in scope * Add test for build.py, deprecate constant * Delete exception which will never get raised * Remove deprecated code slated for removal in 24.7.x * Revert changes from PR 5402 * Add news file * Remove test_build.py test from #5402 * Remove more changes ported over from #5402 * Delete tests for 'conda build --test recipe/' * Undo removal of '_construct_metadata_for_test_from_recipe()' and related tests, delay removal to 24.9.x release * Update news file
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing
sys.exitcall inconda_build/build.pywith the newCondaBuildUserErrorexception for better error handling, along with corresponding unit tests. Removed redundant code frompost_process_files()function, which included asys.exitcall.The changes in this PR are separated out from work previously done by @kenodegard in #5255
Xref #4209
Checklist - did you ...
Add a file to thenewsdirectory (using the template) for the next release's release notes?Add / update outdated documentation?