Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove more 24.7.x deprecations #5406

Merged
merged 17 commits into from
Jul 15, 2024

Conversation

beeankha
Copy link
Member

@beeankha beeankha commented Jul 11, 2024

Description

Code cleanup in preparation for the 24.7.x July release.

Checklist - did you ...

  • Add a file to the news directory (using the template) for the next release's release notes?
  • Add / update necessary tests?
  • Add / update outdated documentation?

@beeankha beeankha added the type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package label Jul 11, 2024
@conda-bot conda-bot added the cla-signed [bot] added once the contributor has signed the CLA label Jul 11, 2024
Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #5406 will not alter performance

Comparing beeankha:remove-more-24.7.x-deprecations (3415415) with main (2a0bf93)

Summary

✅ 3 untouched benchmarks

@beeankha beeankha marked this pull request as ready for review July 11, 2024 21:50
@beeankha beeankha requested a review from a team as a code owner July 11, 2024 21:50
Comment on lines 2871 to 2879
@deprecated(
"3.16.0",
"24.7.0",
addendum=(
"Test built packages instead, not recipes "
"(e.g., `conda build --test package` instead of `conda build --test recipe/`)."
),
deprecation_type=FutureWarning, # we need to warn users, not developers
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops! This was actually just recently marked as deprecated (see #5352). We need to change the removal version to 24.9 instead!!

@kenodegard kenodegard added this to the 24.7.x milestone Jul 12, 2024
@beeankha beeankha enabled auto-merge (squash) July 15, 2024 13:42
@beeankha beeankha merged commit b12a180 into conda:main Jul 15, 2024
28 checks passed
@beeankha beeankha mentioned this pull request Jul 16, 2024
55 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed [bot] added once the contributor has signed the CLA type::task indicates a change that doesn't pertain to the code itself, e.g. updating CI/CQ, rebuilding package
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants