-
Notifications
You must be signed in to change notification settings - Fork 425
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removing glob2 and replacing with glob(,recursive=True) where used. #5005
Conversation
Co-authored-by: Bianca Henderson <[email protected]>
Co-authored-by: Ken Odegard <[email protected]>
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
This is addressing #4792. |
How does this compare to https://docs.python.org/3/library/pathlib.html#pathlib.Path.glob ? |
In general @dholth, or is there a specific instance? |
@dholth comparing $ ls -lahR
total 0
drwxr-xr-x@ 4 kodegard staff 128B Sep 25 11:29 .
drwxr-xr-x 77 kodegard staff 2.4K Sep 25 11:29 ..
-rw-r--r--@ 1 kodegard staff 0B Sep 25 11:29 file
drwxr-xr-x@ 4 kodegard staff 128B Sep 25 11:29 nested
./nested:
total 0
drwxr-xr-x@ 4 kodegard staff 128B Sep 25 11:29 .
drwxr-xr-x@ 4 kodegard staff 128B Sep 25 11:29 ..
-rw-r--r--@ 1 kodegard staff 0B Sep 25 11:29 file
drwxr-xr-x@ 3 kodegard staff 96B Sep 25 11:29 nested
./nested/nested:
total 0
drwxr-xr-x@ 3 kodegard staff 96B Sep 25 11:29 .
drwxr-xr-x@ 4 kodegard staff 128B Sep 25 11:29 ..
-rw-r--r--@ 1 kodegard staff 0B Sep 25 11:29 file
$ python - <<HEREDOC
import glob2, glob, pathlib
print(*glob2.glob('**'))
print(*glob.glob('**', recursive=True))
print(*pathlib.Path.cwd().glob('**'))
HEREDOC
file nested nested/file nested/nested nested/nested/file
file nested nested/file nested/nested nested/nested/file
/Users/kodegard/scratch/glob /Users/kodegard/scratch/glob/nested /Users/kodegard/scratch/glob/nested/nested |
Description
Removed glob2 from code, requirements and recipes.
Checklist - did you ...
news
directory (using the template) for the next release's release notes?