-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEV - Simplify Docker images #841
DEV - Simplify Docker images #841
Conversation
✅ Deploy Preview for conda-store canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few comments, but on the whole this looks like a great simplification. I'm glad you spotted those test files unnecessarily getting copied in, too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for clearing up the questions I had 🚢
0024672
into
trallard/update-dev-environments
This is a stack on top of #838
Description
This PR continues to simplify the development and test setup for conda-store
environment.yaml
files (less files to keep in check/updated)[24.3.0-0](https://hub.docker.com/layers/condaforge/mambaforge/24.3.0-0/images/sha256-21f7908a6c984ae164cb51c8af71ef9901693630f4b744038e5df6ef968d9b05?context=explore)
Pull request checklist
Additional information
Since this stacks on another PR, some integration and unit tests might fail (and will be fixed in #838). For now, the important parts are :
docker compose up
should be working (which it is)I built the Docker images locally, then used these ones for
docker-compose
, and all seemed to work.