DEV - Update dev environments #838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trallard
added
area: dependencies 📦
✅ Deploy Preview for conda-store canceled.
|
3 tasks
peytondmurray
force-pushed
the
trallard/update-dev-environments
branch
from
008810d to
fdc5a05
Compare
|
The last test is being stubborn. I ssh'd into the runner using tmate and ran it manually: |
|
Tried the following with no failures from the
Will continue investigating later. |
|
Yes that is the same that keeps failing... Note that since you are using the |
|
I changed the |
|
Per |
|
I think those are probably not to blame, it's a number of bad escape sequences in the |
|
@trallard I added a line that raises an exception with a bunch of information about the arguments to # CONDA_FLAGS is used by conda-lock in conda_solver.solve_specs_for_arch
try:
conda_flags_name = "CONDA_FLAGS"
# print(f"{conda_flags_name}={conda_flags}")
os.environ[conda_flags_name] = conda_flags
run_lock(
environment_files=[environment_filename],
platforms=platforms,
lockfile_path=lockfile_filename,
conda_exe=conda_command,
with_cuda=cuda_version,
)
except KeyError as exc:
with open(environment_filename, "r") as f:
env_file_content = f.read()
raise DebuggingException(
"\n".join(
[
f"environment_files={[environment_filename]}",
f"platforms={platforms}",
f"lockfile_path={lockfile_filename}",
f"conda_exe={conda_command}",
f"with_cuda={cuda_version}",
f"conda_flags_name={conda_flags_name}",
f"conda_flags={conda_flags}",
f"os.environ={os.environ}",
f"environment_files content={env_file_content}",
]
)
) from exc
finally:
os.environ.pop(conda_flags_name, None)Here's what I found: The only thing that looks strange here is that import pathlib
from conda_lock.conda_lock import run_lock
tmpdir = pathlib.Path('/tmp/tmplmqca7a4')
tmpdir.mkdir(parents=True, exist_ok=True)
environment_filename = tmpdir / 'environment.yaml'
with open(environment_filename, 'w') as f:
f.write('{"name": "pytest-name", "channels": ["main"], "dependencies": ["python"], "variables": null, "prefix": null, "description": ""}')
platforms = ['linux-x64']
lockfile_filename = tmpdir / 'conda-lock.yaml'
conda_command = 'conda'
cuda_version = None
run_lock(
environment_files=[environment_filename],
platforms=platforms,
lockfile_path=lockfile_filename,
conda_exe=conda_command,
with_cuda=cuda_version,
)Strangely I get a separate error, which is that For now I'm just going to try using the |
trallard
commented
Aug 9, 2024
There was a problem hiding this comment.
🎉 Thanks for seeing this over the finish line @peytondmurray
Merging now 🚀
I just cannot approve since I opened the PR but shall be ok
jaimergp
reviewed
Aug 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #801
Description
This PR should remove some unnecessary dependencies and environment file. This was originally done in #801 but with all the recent changes it was easier to clean this up in a separate PR
Pull request checklist
Additional information
How to test