-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set channel priority to strict, print config info #693
Set channel priority to strict, print config info #693
Conversation
✅ Deploy Preview for kaleidoscopic-dango-0cf31d ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @nkaretnikov - I left a few comments and questions.
I generally do not like to use print for what should be logged or streamed, so unless there is a strong reason to use print
this should be changed
conda-store-server/conda_store_server/action/generate_lockfile.py
Outdated
Show resolved
Hide resolved
7f2dd1b
to
973a2a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, this LGTM 🚀 merging now!
This PR sets the channel priority to strict to avoid issues during solves when multiple channels that were not specified are being used. This is done by passing the command line option
--strict-channel-priority
via the environment variableCONDA_FLAGS
, which is used by conda-lock, which is a library conda-store uses to solve dependencies.CONDA_FLAGS
is used because it's a method of passing options that's local to conda-lock as opposed to editing global conda configuration files. Editing user configuration files may lead to unexpected issues in contexts where conda-store is used in standalone mode. Those configuration files affect how conda works outside of conda-store, which might be important to end users.From the documentation at https://docs.conda.io/projects/conda/en/latest/user-guide/tasks/manage-channels.html:
Additionally, this PR adds code that prints useful system information related to conda configuration before the package solving process. This is useful for debugging. The commands used are:
conda/mamba info
, depending on the value ofconda_store.conda_command
conda config --show
conda config --show-sources
.Note that the latter two commands are not supported by mamba, which is why conda is used.
Fixes #359, fixes #659.