Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Channel priority should be set to strict and conda info should be printed with conda-store #359

Closed
costrouc opened this issue Jul 28, 2022 · 7 comments · Fixed by #693
Closed
Assignees
Labels
area: dependencies 📦 Issues related to conda-store dependencies type: bug 🐛 Something isn't working

Comments

@costrouc
Copy link
Member

costrouc commented Jul 28, 2022

Right now some solves are pulling in multiple channels that were not specified.

@costrouc costrouc moved this to 🆕 New in Conda-Store Mar 29, 2023
@costrouc costrouc moved this from 🆕 New to 📋 Backlog in Conda-Store Mar 29, 2023
@costrouc
Copy link
Member Author

costrouc commented Apr 6, 2023

I think that channel priority strict is already set. It would be nice to have the output of:

  • conda info
  • conda config --show

@costrouc
Copy link
Member Author

costrouc commented Apr 6, 2023

You would just be adding commands to the https://github.com/Quansight/conda-store/blob/main/conda-store-server/conda_store_server/build.py#L145-L159 you would be adding an additional command here running conda info/conda config --show.

Or it might be worth running all in the same command. We are not using shell=True. I think that we should just concatenate the logs/outputs together.

@costrouc costrouc moved this from 📋 Backlog to 🔖 Ready in Conda-Store Apr 11, 2023
@costrouc costrouc added this to the Release 0.5.0 milestone Apr 12, 2023
@trallard trallard removed this from the Release 0.5.0 milestone Jul 21, 2023
@trallard trallard added the area: dependencies 📦 Issues related to conda-store dependencies label Jul 21, 2023
@trallard trallard added the needs: investigation 🔎 Someone in the team needs to look into this issue before scoping label Aug 18, 2023
@trallard trallard moved this from New 🚦 to TODO 📬 in conda-store 🐍 Aug 18, 2023
@trallard trallard moved this from TODO 📬 to Ready 🛎️ in conda-store 🐍 Aug 18, 2023
@kcpevey
Copy link
Contributor

kcpevey commented Sep 19, 2023

I'd also like to confirm that we are setting channel priority to strict and ensure that its not pulling in things from defaults or anywhere else.

@kcpevey
Copy link
Contributor

kcpevey commented Sep 19, 2023

Assigning this to @nkaretnikov

@kcpevey kcpevey moved this from Ready 🛎️ to TODO 📬 in conda-store 🐍 Sep 19, 2023
@trallard trallard moved this from TODO 📬 to Ready 🛎️ in conda-store 🐍 Oct 10, 2023
@trallard trallard moved this from Ready 🛎️ to TODO 📬 in conda-store 🐍 Oct 10, 2023
@jaimergp
Copy link
Member

See also #659. Potential duplicate.

@nkaretnikov
Copy link
Contributor

Note: the block of code that Chris refers to above is actually this (no hash was specified in the link and it's been refactored since then):

git show 5f7adfb5737edef307f0a70a42f7d04d66adce30:conda-store-server/conda_store_server/build.py:

145 def build_environment(conda_command, environment_filename, conda_prefix):
146
147     return subprocess.check_output(
148         [
149             conda_command,
150             "env",
151             "create",
152             "-p",
153             conda_prefix,
154             "-f",
155             str(environment_filename),
156         ],
157         stderr=subprocess.STDOUT,
158         encoding="utf-8",
159     )

@nkaretnikov nkaretnikov moved this from TODO 📬 to In Progress 🏗 in conda-store 🐍 Dec 10, 2023
nkaretnikov added a commit that referenced this issue Dec 11, 2023
@nkaretnikov nkaretnikov moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Dec 11, 2023
@nkaretnikov
Copy link
Contributor

Status update: this should be fixed by #693.

@nkaretnikov nkaretnikov added status: in progress 🏗 and removed needs: investigation 🔎 Someone in the team needs to look into this issue before scoping labels Dec 12, 2023
nkaretnikov added a commit to nkaretnikov/conda-store that referenced this issue Dec 18, 2023
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 💪🏾 in conda-store 🐍 Dec 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 Issues related to conda-store dependencies type: bug 🐛 Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants