Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra redis and move to using built images for examples #620

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dcmcand
Copy link
Contributor

@dcmcand dcmcand commented Oct 12, 2023

Fixes #616
Fixes #617
Part of #599

Description

Updates docker-compose files in examples directory

This pull request:

  • removes extra redis instance from examples/docker/docker-compose.yaml
  • sets conda-store-worker and conda-store-server to use quansight/conda-store-server in examples/docker/docker-compose.yaml
  • sets conda-store-worker and conda-store-server to use quansight/conda-store-server in examples/docker-without-nfs/docker-compose.yaml

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for kaleidoscopic-dango-0cf31d canceled.

Name Link
🔨 Latest commit d70fd4d
🔍 Latest deploy log https://app.netlify.com/sites/kaleidoscopic-dango-0cf31d/deploys/6528577356037200093c0c9a

@costrouc
Copy link
Member

@dcmcand I'll be honest this is a set of examples I haven't tested in a LONG time. Actually all of the examples haven't been tested in awhile. The docker-compose.yaml in the root of the repository is the most tested.

Should we be testing examples?

Copy link
Member

@costrouc costrouc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise this LGTM. Looks good for merging. I was able to run this locally.

@dcmcand
Copy link
Contributor Author

dcmcand commented Oct 16, 2023

I think that examples should be tested. I know when I start using a new project, I often use the example as a getting started place. If they aren't tested and don't work, that would be pretty frustrating.

@dcmcand dcmcand merged commit 301bca7 into conda-incubator:main Oct 16, 2023
11 checks passed
@dcmcand dcmcand deleted the dcmcand-remove-extra-redis branch October 16, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done 💪🏾
3 participants