[BUG] - Review and improve docker images

[pavithraes]

Describe the bug

Currently, we have 2 Dockerfiles used to build images:

• conda-store, which does an editable install:
  

  conda-store/conda-store/Dockerfile

  Lines 22 to 23 in 64552a2

  	RUN cd /opt/conda-store && \
  	pip install -e .

  
  ❗️this is also the file used during releases which should not be the case
• conda-store-server, which installs a local directory:
  

  conda-store/conda-store-server/Dockerfile

  Lines 49 to 51 in 64552a2

  	RUN ls -la /opt/conda-store-server/ && \
  	cd /opt/conda-store-server && \
  	/opt/conda/envs/conda-store-server/bin/pip install .

These are used by the docker-compose.yaml in:

• the root dir, used by developers for local development
• the examples dir intended for end-users --❗️we should use released versions from PyPI or conda-forge here, or refer to the docker images built on releases
  • docker/docker-compose.yaml - ❗️this file also has defined redis twice, which causes errors while building
  • docker-without-nfs/docker-compose.yaml

☝🏽Additionally, the port number 5000, where the UI is deployed for development does not work reliably on MacOS. We need to pick default ports that work on all platforms.

Expected behavior

We need to have separate images for building dev and stable versions of conda-store. The releases should use to stable versions.

Anything else?

xref: conda-incubator/conda-store-ui#335, #566

[pavithraes]

I think we can use the docker-compose.yaml in conda-store-ui, as is and as a ref, for the examples directory.

[dcmcand]

To summarize:

1. conda-store should have a dev target and a release target for the Dockerfile. Dev target should install dependencies in editable mode, release target should not. ([BUG] - conda-store image needs a release target and dev target in the Dockerfile #614 )
2. examples/docker/docker-compose.yaml should use a dockerhub image rather than building from source ([BUG] - examples/docker/docker-compose.yaml builds from source #616 ).
3. examples/docker/docker-compose.yaml has redis defined twice ([BUG] - examples/docker/docker-compose.yaml has redis defined twice #617).
4. examples/docker-without-nfs/docker-compose.yaml should use a dockerhub image rather than building from source ([BUG] - examples/docker/docker-compose.yaml builds from source #616 ) .
5. default port of 5000 is problematic and should be changed ([BUG] - port 5000 is a problem on MacOS #618 ).

Did I miss anything @pavithraes?

[kcpevey]

@dcmcand it looks like the review is complete and all of the issues have been opened as separate issues. Can we close this in favor or the individual issues?

[dcmcand]

Yes @kcpevey, we can close this one. The only outstanding issue is #618. That should be a pretty easy one.