Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - conda-store image needs a release target and dev target in the Dockerfile #614

Closed
dcmcand opened this issue Oct 12, 2023 · 1 comment · Fixed by #621
Closed

[BUG] - conda-store image needs a release target and dev target in the Dockerfile #614

dcmcand opened this issue Oct 12, 2023 · 1 comment · Fixed by #621

Comments

@dcmcand
Copy link
Contributor

dcmcand commented Oct 12, 2023

Describe the bug

Split from #599

conda-store, which does an editable install:

conda-store/conda-store/Dockerfile

Lines 22 to 23 in 64552a2
RUN cd /opt/conda-store && \
pip install -e .

❗️this is also the file used during releases which should not be the case

Expected behavior

To fix this, refactor conda-store/Dockerfile to have 2 different build targets.

  1. The dev target should install dependencies in editable mode as the the current file does
  2. The release target should not install dependencies in editable mode
  3. The .github/workflows/build_docker_image.yaml workflow should be changed to use the release target

How to Reproduce the problem?

N/A

Output

No response

Versions and dependencies used.

No response

Anything else?

No response

@dcmcand
Copy link
Contributor Author

dcmcand commented Oct 12, 2023

I am working on this one.

@dcmcand dcmcand self-assigned this Oct 13, 2023
@dcmcand dcmcand moved this from New 🚦 to In Progress 🏗 in conda-store 🐍 Oct 13, 2023
@dcmcand dcmcand moved this from In Progress 🏗 to In review 👀 in conda-store 🐍 Oct 13, 2023
@github-project-automation github-project-automation bot moved this from In review 👀 to Done 💪🏾 in conda-store 🐍 Oct 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant