Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH - Add Playwright for automated testing #293

Merged
merged 25 commits into from
Oct 24, 2023
Merged

ENH - Add Playwright for automated testing #293

merged 25 commits into from
Oct 24, 2023

Conversation

kcpevey
Copy link
Contributor

@kcpevey kcpevey commented Sep 18, 2023

Fixes #290

Description

This pull request:

  • adds playwright tests
    • these run inside and outside of pytest
  • grabs some screenshots and uploads as artifacts (most for demo purposes, as docs are developed, these can modified/expanded)
  • saves a video of the playwright test
  • adds running the playwright tests and the yarn test in the github ci

Pull request checklist

  • Did you test this change locally?
  • Did you update the documentation (if required)?
  • Did you add/update relevant tests for this change (if required)?

Additional information

@trallard trallard changed the title Add Playwright ENH - Add Playwright for automated testing Sep 20, 2023
@trallard trallard added type: enhancement 💅🏼 New feature or request area: testing ✅ Design of the test infrastructure and everything related impact: high 🟥 This issue affects most of the nebari users or is a critical issue labels Sep 20, 2023
@trallard trallard added this to the 🚀 JATIC - Q1 milestone Sep 20, 2023
@trallard
Copy link
Collaborator

Is this ready for review @kcpevey?

@kcpevey
Copy link
Contributor Author

kcpevey commented Sep 26, 2023

I just can't get the ports sorted out inside of CI. My local setup has to be different because I can't use 5000 so I switch to 8080 then the new UI shows up on 8081. What's happening on CI is totally different and I dont understand it. I dont have time to debug this this week. If someone else wants to have a look that would be great.

Once the ports are specified correctly, I expect this to pass.

Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a couple of questions, I'm a little puzzled because there's a mix of the use of the port 5000, 8080 and 8081 that I think may be causing the failures.

.env.example Outdated Show resolved Hide resolved
.env.tpl Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
@kcpevey
Copy link
Contributor Author

kcpevey commented Oct 6, 2023

This is ready for final review @steff456

Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one question, overall this PR looks really good @kcpevey!

environment_dev.yml Show resolved Hide resolved
Copy link
Contributor

@steff456 steff456 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kcpevey kcpevey merged commit 9e97f7b into main Oct 24, 2023
2 checks passed
@kcpevey kcpevey deleted the add_playwright branch November 27, 2023 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ✅ Design of the test infrastructure and everything related impact: high 🟥 This issue affects most of the nebari users or is a critical issue status: in progress 🏗 type: enhancement 💅🏼 New feature or request
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[ENH] - Add playwright integration tests to run on PRs
4 participants