-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH - Add Playwright for automated testing #293
Conversation
Is this ready for review @kcpevey? |
I just can't get the ports sorted out inside of CI. My local setup has to be different because I can't use 5000 so I switch to 8080 then the new UI shows up on 8081. What's happening on CI is totally different and I dont understand it. I dont have time to debug this this week. If someone else wants to have a look that would be great. Once the ports are specified correctly, I expect this to pass. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of questions, I'm a little puzzled because there's a mix of the use of the port 5000, 8080 and 8081 that I think may be causing the failures.
This is ready for final review @steff456 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left one question, overall this PR looks really good @kcpevey!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Fixes #290
Description
This pull request:
Pull request checklist
Additional information