-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Update dep pinnings #80
Conversation
Restrict python and pytorch version ranges as specified upstream. This is mentioned in conda-forge#22
…nda-forge-pinning 2023.11.08.08.48.42
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
Not sure why we're trying to run almost all of the unit tests, but these tests are failing on test_draw_boxes. Upstream has identified the issue as something caused by a change with pillow 10.1.0, so it is unrelated to this PR. They fixed the test by updating the reference image in a later release, so it's fine that this test fails. I think the best approach would be to skip that test because it doesn't indicate a problem for downstream users. |
@conda-forge-admin, please rerender |
…nda-forge-pinning 2023.11.09.20.47.34
Because just import tests or small test scripts are woefully inadequate for testing whether a given package is fully functional. I think it should be our standard everywhere (modulo timeout/resource issues). PS. Thanks for tackling this! 🙏 |
yeah... but it adds 10MB to the package..... so its less than idea IMO. |
Thank you! |
So let's split off the tests into a separate output - best of both worlds (except that you don't like multi output recipes 😜) |
lol, that is a true statement .... |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)Closes #79
Partial #22
The purpose of this PR is to update the pytorch pinnings to match upstream according to their stated compatability matrix and according to their runtime checks.
I did this by
As a bonus, I also:
--no-deps --no-build-isolation
which are not automatically added by us when pip is called from a script in the outputs section instead of from a build script in the top-level package.