Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recipe improvements #22

Open
3 of 9 tasks
h-vetinari opened this issue Mar 16, 2021 · 5 comments
Open
3 of 9 tasks

Recipe improvements #22

h-vetinari opened this issue Mar 16, 2021 · 5 comments

Comments

@h-vetinari
Copy link
Member

h-vetinari commented Mar 16, 2021

Some open points remaining from (OP of) #12:

  • build with cuda
  • build with ffmpeg support
  • turn into multi-output recipe (e.g. with/without ffmpeg/image support)?
  • package c++ lib separately?
  • build for osx
  • build for win
  • double-check PTX vs. cuda-arches, see this comment
  • depend on pillow-simd, see Package pillow-simd? pillow-feedstock#103
  • Split test files into a separate packages to reduce download size from 7MB to 1MB

CC @hmaarrfk @isuruf

@hmaarrfk
Copy link
Contributor

Thoughts:

Didn't know this was dropped but good to keep track!

@h-vetinari
Copy link
Member Author

package c++ lib separately?

Maybe just create a split package and have the lib package not depend on python https://github.com/conda-forge/opencv-feedstock/blob/master/recipe/meta.yaml#L1

That's (another aspect of) what I meant by making the recipe have multiple outputs

build for osx

Thanks!!!!

That credit belongs to @isuruf

build for win

Didn't know this was dropped but good to keep track!

When I picked up the feedstock again, linux was the only build variant... Not sure how much effort this would be, but the pytorch channel has windows builds (even with cuda).

@hmaarrfk
Copy link
Contributor

Also cross referencing this issue:
conda-forge/pytorch-cpu-feedstock#40 (comment)

@Tobias-Fischer
Copy link
Contributor

It would also be great if the correct version of pytorch is being pinned. Currently there can be a mismatch between the pytorch and torchvision versions. The compatibility table is shown in their GitHub repo

@hmaarrfk
Copy link
Contributor

As test files are being copied into the recipe archive, the many binary files are actually increasing the size of said archive:
image

@h-vetinari h-vetinari mentioned this issue Jan 24, 2022
5 tasks
carterbox added a commit to carterbox/torchvision-feedstock that referenced this issue Nov 8, 2023
Restrict python and pytorch version ranges as specified upstream.
This is mentioned in conda-forge#22
@carterbox carterbox mentioned this issue Nov 8, 2023
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants