Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding altair_tiles #25760

Merged
merged 3 commits into from
Mar 17, 2024
Merged

Adding altair_tiles #25760

merged 3 commits into from
Mar 17, 2024

Conversation

binste
Copy link
Member

@binste binste commented Mar 16, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • [ x License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/altair_tiles/altair_tiles) and found some lint.

Here's what I've got...

For recipes/altair_tiles/altair_tiles:

  • The home item is expected in the about section.
  • Please do not delete the example recipe found in recipes/example/meta.yaml.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/altair_tiles) and found some lint.

Here's what I've got...

For recipes/altair_tiles:

  • The home item is expected in the about section.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/altair_tiles) and found it was in an excellent condition.

@binste
Copy link
Member Author

binste commented Mar 16, 2024

@conda-forge/help-python, ready for review. Thanks! :)

@xhochy xhochy merged commit c6d9c7a into conda-forge:main Mar 17, 2024
5 checks passed
@binste
Copy link
Member Author

binste commented Mar 17, 2024

Awesome, thank you for the quick review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants