Add altair all package corresponding to pip "extras" group #53

joelostblom · 2024-03-11T17:57:34Z

Checklist

Used a personal fork of the feedstock to propose changes
Bumped the build number (if the version is unchanged)
Reset the build number to 0 (if the version changed)
Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
Ensured the license file is being packaged.

conda-forge-webservices · 2024-03-11T17:57:42Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'altair-all' output doesn't have any tests.

joelostblom

@jonmmease @binste @mattijn This is an attempt to create a conda package for the new altair['all'] pip extras group that we added in vega/altair#3354 vega/altair#2818.

I used the recipes of matplotlib, seaborn, and opencv as a template, together with info from this and this discussion.

In addition to my questions in the inline comments, I noticed that seaborn took the approaches of creating a -base package for the barebones install and then have the conda package that just contains the package name correspond to the full install with the [all] group. matplotlib does something similar. We could consider doing this as well, although I personally think that it is clearer if we use altair-all to correspond to altair[all].

If we create altair-all here, we should decide where anywidget and vega-datasets goes. These are already part of the base altair package in conda (probably for testing purposes), but we could break them out into the altair-all package instead if we want. I vote doing whatever is the simplest, which might be to leave them where they are now, but open to hear other thoughts.

Note that although I could run build-locally.py without issues wit hthis recipe, I couldn't find a way to install and test the created packages.

joelostblom · 2024-03-11T17:58:39Z

recipe/meta.yaml

@@ -11,46 +11,64 @@ source:
  sha256: 2ad7f0c8010ebbc46319cc30febfb8e59ccf84969a201541c207bc3a4fa6cf81

 build:
-  number: 0
+  number: 1
  noarch: python
  script: {{ PYTHON }} -m pip install . -vv


For some reason {{ PYTHON }} did not work when running ./build-locally.py and I had to replace it with just python, but since it never caused issues on conda-forge, I'm leaving it as is

Actually this seems to be the reason for the failing tests as well... @ocefpaf Do you know why this is happening since the docs mention that we should use {{ PYTHON }}?

Not sure if this is still a problem but most of the time, issues like that one, are solved by re-rendering the feedstock.

Thank you @ocefpaf , I just tried re-rendering and I'm still seeing the same error in the pipelines https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=895875&view=results

joelostblom · 2024-03-11T17:59:21Z

recipe/meta.yaml

+        - vega_datasets >=0.9.0
+        - anywidget >=0.9.0


These were added previously, vega_datasets since 6 years ago, and anywidget since 5.1

joelostblom · 2024-03-11T18:01:00Z

recipe/meta.yaml

+        - pyarrow >=11
+        - vegafusion-python-embed >=1.5.0
+        - {{ pin_subpackage('altair', exact=True) }}
+        #   - altair_tiles >=0.3.0


I couldn't find a way to install from pip in the conda recipe as it seems like the approach used in local conda envs (pip:) does not work. If anyone knows how to install altair_tiles from pip as part of this setup file please chime in (or if you feel like creating a conda package @binste).

Thank you very much @joelostblom for this PR! I've never created a conda package before so appreciate it that you started this :)

I might have some time on the weekend to try to create a conda package as well for altair_tiles so that we can include it here.

joelostblom · 2024-03-11T18:01:37Z

recipe/meta.yaml

+        - vl-convert-python >=1.1.0
+        - pyarrow >=11
+        - vegafusion-python-embed >=1.5.0
+        - {{ pin_subpackage('altair', exact=True) }}


I copied this from the seboarn recipe and saw that matplotlib has something similar although slightly different. Let me know if this looks reasonable

nice, I hadn't seen this before

joelostblom · 2024-03-11T18:06:32Z

recipe/meta.yaml

+    - joelostblom
+    - jonmmease
+    - binste
+    - mattijn


I added everyone listed on PyPI as a package maintainer here so that we get tagged in the PRs made to this repo. Let me know if you want you name removed

recipe/meta.yaml

jonmmease

Thanks for tackling this @joelostblom!

recipe/meta.yaml

jonmmease · 2024-03-13T11:07:25Z

recipe/meta.yaml

+        - vl-convert-python >=1.1.0
+        - pyarrow >=11
+        - vegafusion-python-embed >=1.5.0
+        - {{ pin_subpackage('altair', exact=True) }}


nice, I hadn't seen this before

jonmmease · 2024-03-13T11:07:54Z

recipe/meta.yaml

+        imports:
+          - altair
+          - vegafusion
+          - vl-convert-python


I think this will need to be vl_convert to match the import rather than the package name

Good catch, fixed!

joelostblom · 2024-03-14T15:21:50Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.03.14.11.25.07

conda-forge-webservices · 2024-03-14T15:51:52Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

…nda-forge-pinning 2024.03.14.11.25.07

ocefpaf · 2024-03-14T16:12:24Z

The main issue here was b/c multiple outputs are a different beast and we need a .sh script for them.

joelostblom · 2024-03-14T16:15:04Z

Super, thanks for your help @ocefpaf ! We will wait to have conda package for the altair-tiles dependency and then I will mark this as ready for review.

binste · 2024-03-16T15:09:41Z

I've now created a recipe for altair_tiles and am waiting for a review at conda-forge/staged-recipes#25760. I'll let you know once altair_tiles is in conda-forge :)

binste · 2024-03-17T09:55:42Z

altair_tiles is available on conda-forge: https://anaconda.org/conda-forge/altair_tiles I installed and tested it, looks good to me! I'll add the conda install commands to the altair_tiles docs soon

conda-forge-webservices · 2024-03-17T16:52:27Z

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

It looks like the 'altair-all' output doesn't have any tests.

joelostblom · 2024-03-17T16:57:38Z

@conda-forge-admin, please rerender

…nda-forge-pinning 2024.03.16.19.50.45

joelostblom · 2024-03-17T17:10:18Z

Thanks @binste! I uncommented those lines, marked this as ready for review and -rerequested reviews from everyone who commented so far (I'm unsure about the checkbox for the packaging of a license file; do we need to manually upload the Altair license file as part of this PR?).

joelostblom added 4 commits March 11, 2024 10:54

Add altair all

377605d

Add additional recipe maintainers

246666c

Bump build number

35e3c16

Remvoe trailing newline

0cbaa61

Fix typo

53341d6

joelostblom commented Mar 11, 2024

View reviewed changes

jonmmease reviewed Mar 13, 2024

View reviewed changes

Add vegafusion and fix vl_convert test

7a160d4

conda-forge-webservices[bot] and others added 3 commits March 14, 2024 15:23

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

7c01e9d

…nda-forge-pinning 2024.03.14.11.25.07

fix multiple output recipe

37f45fa

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

2f5a76d

…nda-forge-pinning 2024.03.14.11.25.07

ocefpaf added 3 commits March 14, 2024 12:55

add build script

5b2bcd2

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.31.1, and co…

6773a53

…nda-forge-pinning 2024.03.14.11.25.07

don't use split name

78399db

Add altair_tiles

db9cfc4

MNT: Re-rendered with conda-build 24.1.2, conda-smithy 3.32.0, and co…

7999699

…nda-forge-pinning 2024.03.16.19.50.45

joelostblom marked this pull request as ready for review March 17, 2024 17:08

joelostblom requested review from ellisonbg and jakevdp as code owners March 17, 2024 17:08

joelostblom requested review from ocefpaf and binste March 17, 2024 17:08

joelostblom requested a review from jonmmease March 17, 2024 17:08

ocefpaf merged commit b3e4e97 into conda-forge:main Mar 18, 2024
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add altair all package corresponding to pip "extras" group #53

Add altair all package corresponding to pip "extras" group #53

joelostblom commented Mar 11, 2024 •

edited

Loading

conda-forge-webservices bot commented Mar 11, 2024

joelostblom left a comment

joelostblom Mar 11, 2024

joelostblom Mar 11, 2024

ocefpaf Mar 14, 2024

joelostblom Mar 14, 2024

joelostblom Mar 11, 2024

joelostblom Mar 11, 2024

binste Mar 13, 2024

joelostblom Mar 11, 2024

jonmmease Mar 13, 2024

joelostblom Mar 11, 2024

jonmmease left a comment

jonmmease Mar 13, 2024

jonmmease Mar 13, 2024

joelostblom Mar 13, 2024

joelostblom commented Mar 14, 2024

conda-forge-webservices bot commented Mar 14, 2024

ocefpaf commented Mar 14, 2024

joelostblom commented Mar 14, 2024

binste commented Mar 16, 2024

binste commented Mar 17, 2024 •

edited

Loading

conda-forge-webservices bot commented Mar 17, 2024

joelostblom commented Mar 17, 2024

joelostblom commented Mar 17, 2024 •

edited

Loading

Add altair all package corresponding to pip "extras" group #53

Add altair all package corresponding to pip "extras" group #53

Conversation

joelostblom commented Mar 11, 2024 • edited Loading

conda-forge-webservices bot commented Mar 11, 2024

joelostblom left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jonmmease left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

joelostblom commented Mar 14, 2024

conda-forge-webservices bot commented Mar 14, 2024

ocefpaf commented Mar 14, 2024

joelostblom commented Mar 14, 2024

binste commented Mar 16, 2024

binste commented Mar 17, 2024 • edited Loading

conda-forge-webservices bot commented Mar 17, 2024

joelostblom commented Mar 17, 2024

joelostblom commented Mar 17, 2024 • edited Loading

joelostblom commented Mar 11, 2024 •

edited

Loading

binste commented Mar 17, 2024 •

edited

Loading

joelostblom commented Mar 17, 2024 •

edited

Loading