Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcufile recipe #21908
Add libcufile recipe #21908
Changes from 7 commits
b5e65d6
c9f1fc1
372f26e
488dbda
4279763
1a4969e
0c20a35
fbac483
e41a0ac
5d18921
cdbcdba
9e6d832
ee146b6
9ad326f
64b3393
a90df31
702a290
dbbd113
8e21b79
1970a53
6158a96
7497aed
c8e9e42
a17812a
5317c44
f264627
f93c0b2
11ee0dc
79c750a
c8de857
54a340a
178099f
1ba2afe
76cd37c
61ab85d
93593ce
498ac3a
89875b4
86b9763
7939393
9cd3345
2556d27
9d4601f
0452766
28723e1
f03b6c1
be9e78c
900a8aa
1ed22aa
25ee3e5
c671519
afa2ad6
ba1e05d
ca53dd3
21f096d
694ac62
32b88d0
3cda9c8
23d673c
ebfbf07
f32c306
7456ba7
296b975
08a0182
4b402b1
9e35a54
c1f3c4b
5b28f1b
08a70e1
e1d5f02
16cfcdd
21053dd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need this Windows build script, but we do need a linux one to set up the targets directory:
https://github.com/conda-forge/staged-recipes/pull/21723/files#diff-e5bafa1dffa25db6c210c96887404cd7168b4c02772daf9fa5cbedb52b5fbd0e
The pkgconfig name will need to be updated to "cufile*.pc"
And the ppc64le line can be dropped
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if it's already been checked, but does cuFile use the file put here as expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a good question. Will ask
It's possible we would need to set
CUFILE_ENV_PATH_JSON
for this to work. That could be done with activation scriptSuppose a fair question would be whether we want to do this or whether users would rather maintain their own configuration file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like we don't need this file. So we dropped it to avoid confusion
We can always revisit this in the feedstock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@adibbley, what do you think about including
man
inlibcufile
? Wonder if it is helpful for the end user to have access to theman
files for configuration, etc.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes it should be there, it is in the 12.0.0 branch of the original recipe.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which test here is failing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah nvm. It's
gds/samples
(from CI)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test flags should also be
-d
once they are shuffled to the expected location.