Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcufile recipe #21908

Merged
merged 72 commits into from
Apr 12, 2023
Merged

Add libcufile recipe #21908

merged 72 commits into from
Apr 12, 2023

Conversation

mroeschke
Copy link
Contributor

This recipe is based on the libcufile recipe in the nvidia conda channel. This is my first time submitting a recipe.

Note: I noticed the nvidia conda channel recipe doesn't have a test. Is that expected?

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found some lint.

Here's what I've got...

For recipes/libcufile:

  • The license item is expected in the about section.
  • The summary item is expected in the about section.
  • The recipe must have some tests.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [2]

@mroeschke
Copy link
Contributor Author

cc @jakirkham @adibbley xref #21382

@jakirkham jakirkham mentioned this pull request Jan 31, 2023
49 tasks
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Matthew! 🙏

Had a couple initial suggestions below. Should fix the linter error

recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found some lint.

Here's what I've got...

For recipes/libcufile:

  • The summary item is expected in the about section.
  • The recipe must have some tests.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [2]

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found some lint.

Here's what I've got...

For recipes/libcufile:

  • The summary item is expected in the about section.
  • The recipe must have some tests.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a couple suggestions on the recent linter comments that should hopefully address them

recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
files:
- lib/libcufile*.so
- include/cufile*
- man
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adibbley, what do you think about including man in libcufile? Wonder if it is helpful for the end user to have access to the man files for configuration, etc.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it should be there, it is in the 12.0.0 branch of the original recipe.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- man

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found some lint.

Here's what I've got...

For recipes/libcufile:

  • The recipe must have some tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found it was in an excellent condition.

recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
@@ -0,0 +1,17 @@
if not exist %PREFIX% mkdir %PREFIX%
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need this Windows build script, but we do need a linux one to set up the targets directory:
https://github.com/conda-forge/staged-recipes/pull/21723/files#diff-e5bafa1dffa25db6c210c96887404cd7168b4c02772daf9fa5cbedb52b5fbd0e
The pkgconfig name will need to be updated to "cufile*.pc"
And the ppc64le line can be dropped

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcufile) and found it was in an excellent condition.

recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
@mroeschke mroeschke marked this pull request as ready for review April 10, 2023 17:58
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
- {{ pin_subpackage("libcufile", max_pin="x") }}
files:
- lib/libcufile*.so.*
- etc/cufile.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if it's already been checked, but does cuFile use the file put here as expected?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. Will ask

It's possible we would need to set CUFILE_ENV_PATH_JSON for this to work. That could be done with activation script

Suppose a fair question would be whether we want to do this or whether users would rather maintain their own configuration file

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like we don't need this file. So we dropped it to avoid confusion

We can always revisit this in the feedstock

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Keith! 🙏

Agree with moving man to -dev. Have suggested some changes for that

Following up on cufile.json offline

recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Outdated Show resolved Hide resolved
recipes/libcufile/meta.yaml Show resolved Hide resolved
- {{ pin_subpackage("libcufile", max_pin="x") }}
files:
- lib/libcufile*.so.*
- etc/cufile.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good question. Will ask

It's possible we would need to set CUFILE_ENV_PATH_JSON for this to work. That could be done with activation script

Suppose a fair question would be whether we want to do this or whether users would rather maintain their own configuration file

recipes/libcufile/meta.yaml Show resolved Hide resolved
@jakirkham jakirkham merged commit 63066d2 into conda-forge:main Apr 12, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

@mroeschke mroeschke deleted the libcufile branch April 12, 2023 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants