-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_abi #10760
Merged
Merged
Add python_abi #10760
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
a741772
Add python_abi
isuruf 843b5e6
Fix abi tag for not linux
isuruf 04a1dfc
Fix python requirement
isuruf 39207e4
Skip pypy until that package is built.
isuruf 811ec79
Remove 3.4
isuruf c41cffa
Add dummy test
isuruf 493d275
Fix typo
isuruf 20cd929
Update test and add license_family
isuruf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| Copyright (c) 2015-2018, conda-forge | ||
| All rights reserved. | ||
|
|
||
| Redistribution and use in source and binary forms, with or without | ||
| modification, are permitted provided that the following conditions are met: | ||
|
|
||
| * Redistributions of source code must retain the above copyright notice, this | ||
| list of conditions and the following disclaimer. | ||
|
|
||
| * Redistributions in binary form must reproduce the above copyright notice, | ||
| this list of conditions and the following disclaimer in the documentation | ||
| and/or other materials provided with the distribution. | ||
|
|
||
| * Neither the name of staged-recipes nor the names of its | ||
| contributors may be used to endorse or promote products derived from | ||
| this software without specific prior written permission. | ||
|
|
||
| THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" | ||
| AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE | ||
| IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE | ||
| DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT HOLDER OR CONTRIBUTORS BE LIABLE | ||
| FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL | ||
| DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR | ||
| SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER | ||
| CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, | ||
| OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE | ||
| OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| python_abi_tag: | ||
| - cp27mu # [linux] | ||
| - cp27m # [not linux] | ||
| - cp35m | ||
| - cp36m | ||
| - cp37m | ||
| - cp38 | ||
| - pypy27_pp73 | ||
| - pypy36_pp73 | ||
|
|
||
| python_requirement: | ||
| - 2.7.* | ||
| - 3.5.* | ||
| - 3.6.* | ||
| - 3.7.* | ||
| - 3.8.* | ||
| - 2.7.* *_73_pypy | ||
| - 3.6.* *_73_pypy | ||
|
|
||
| python_version: | ||
| - 2.7 | ||
| - 3.5 | ||
| - 3.6 | ||
| - 3.7 | ||
| - 3.8 | ||
| - 2.7 | ||
| - 3.6 | ||
|
|
||
| python_impl: | ||
| - cpython | ||
| - cpython | ||
| - cpython | ||
| - cpython | ||
| - cpython | ||
| - pypy | ||
| - pypy | ||
|
|
||
| zip_keys: | ||
| - | ||
| - python_abi_tag | ||
| - python_version | ||
| - python_requirement | ||
| - python_impl |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package: | ||
| name: python_abi | ||
| version: {{ python_version }} | ||
|
|
||
| build: | ||
| number: 0 | ||
| string: {{ python_abi_tag }} | ||
| track_features: pypy # [python_impl == "pypy"] | ||
| skip: True # [python_impl == "pypy"] | ||
|
|
||
| requirements: | ||
| run: | ||
| - python {{ python_requirement }} | ||
| run_constrained: | ||
| - pypy <0a0 # [python_impl == "cpython"] | ||
|
|
||
| test: | ||
| commands: | ||
| - python --version | ||
|
|
||
| about: | ||
| home: https://github.com/conda-forge/python_abi-feedstock | ||
| summary: Metapackage to select python implementation | ||
| license: BSD-3-Clause | ||
| license_family: BSD | ||
| license_file: LICENSE | ||
isuruf marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| extra: | ||
| recipe-maintainers: | ||
| - isuruf | ||
| - jjhelmus | ||
| - mattip | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typical drawback applies here: If you'd want to change/refine the dependencies in the future, a new build would have the same filename. You'd have to change the version number to something like
x.y.z.0.custom_number(w/o relying on repodata patching).There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing the typical
python_abi[build=*_abi]thing, i.e.,h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}_{{ python_abi_tag }}(well
{{ PKG_BUILDNUM }}_{{ python_abi_tag }}would also work since we don't have build deps).Sure it's a little less convenient to have the user type
python=3.8.2=*cp38python=3.8.2=cp38, but at least we're more flexible then.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. @jjhelmus, @msarahan, any particular idea that you like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make a metapackage
cpythonandpypyto make it easier for the user to switch.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(They wouldn't be a requirement of any package, but they are just there for users to easily remember. Just like
nomklis)