Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python_abi #10760

Merged
merged 8 commits into from
Feb 5, 2020
Merged

Add python_abi #10760

merged 8 commits into from
Feb 5, 2020

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Feb 4, 2020

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml"
  • License file is packaged (see here for an example)
  • Source is from official source
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged)
  • If static libraries are linked in, the license of the static library is packaged.
  • Build number is 0
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details)
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/python_abi) and found some lint.

Here's what I've got...

For recipes/python_abi:

  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/python_abi) and found some lint.

Here's what I've got...

For recipes/python_abi:

  • The top level meta key tests is unexpected
  • The recipe must have some tests.

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/python_abi) and found it was in an excellent condition.

@isuruf isuruf requested a review from jjhelmus February 4, 2020 20:39
@scopatz
Copy link
Member

scopatz commented Feb 5, 2020

This LGTM now!

@isuruf
Copy link
Member Author

isuruf commented Feb 5, 2020

Merging as conda-forge/python-feedstock#309 got merged.

@isuruf isuruf merged commit dfdf9f5 into conda-forge:master Feb 5, 2020
@jjhelmus
Copy link
Contributor

jjhelmus commented Feb 6, 2020

GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there

Please follow these instructions in the future

@isuruf isuruf deleted the python_abi branch February 6, 2020 18:05
@isuruf
Copy link
Member Author

isuruf commented Feb 6, 2020

Oops. Sorry about that. Do you still want to be a maintainer or shall I remove you?

@jjhelmus
Copy link
Contributor

jjhelmus commented Feb 6, 2020

I've removed myself.


build:
number: 0
string: {{ python_abi_tag }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The typical drawback applies here: If you'd want to change/refine the dependencies in the future, a new build would have the same filename. You'd have to change the version number to something like x.y.z.0.custom_number (w/o relying on repodata patching).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any other suggestions?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing the typical python_abi[build=*_abi] thing, i.e.,
h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}_{{ python_abi_tag }}
(well {{ PKG_BUILDNUM }}_{{ python_abi_tag }} would also work since we don't have build deps).
Sure it's a little less convenient to have the user type python=3.8.2=*cp38 python=3.8.2=cp38, but at least we're more flexible then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. @jjhelmus, @msarahan, any particular idea that you like?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can make a metapackage cpython and pypy to make it easier for the user to switch.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(They wouldn't be a requirement of any package, but they are just there for users to easily remember. Just like nomkl is)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

5 participants