-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add python_abi #10760
Add python_abi #10760
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/python_abi:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/python_abi:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This LGTM now! |
Merging as conda-forge/python-feedstock#309 got merged. |
Please follow these instructions in the future |
Oops. Sorry about that. Do you still want to be a maintainer or shall I remove you? |
I've removed myself. |
|
||
build: | ||
number: 0 | ||
string: {{ python_abi_tag }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The typical drawback applies here: If you'd want to change/refine the dependencies in the future, a new build would have the same filename. You'd have to change the version number to something like x.y.z.0.custom_number
(w/o relying on repodata patching).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any other suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doing the typical python_abi[build=*_abi]
thing, i.e.,
h{{ PKG_HASH }}_{{ PKG_BUILDNUM }}_{{ python_abi_tag }}
(well {{ PKG_BUILDNUM }}_{{ python_abi_tag }}
would also work since we don't have build deps).
Sure it's a little less convenient to have the user type python=3.8.2=*cp38
python=3.8.2=cp38
, but at least we're more flexible then.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can make a metapackage cpython
and pypy
to make it easier for the user to switch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(They wouldn't be a requirement of any package, but they are just there for users to easily remember. Just like nomkl
is)
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details)