Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use generic blas for building #167

Closed
wants to merge 1 commit into from
Closed

Use generic blas for building #167

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion recipe/build_pytorch.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ if [[ "$OSTYPE" == "darwin"* ]]; then
export USE_DISTRIBUTED=1

if [[ "$target_platform" == "osx-arm64" ]]; then
export BLAS=OpenBLAS
export BLAS=Generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@isuruf should we try generic (lowercase) here?

https://github.com/pytorch/pytorch/blob/789070986c32835bd03f2d14bd77dd31e59ef95d/cmake/Modules/FindBLAS.cmake#L292-L309

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OTOH https://github.com/pytorch/pytorch/blob/789070986c32835bd03f2d14bd77dd31e59ef95d/cmake/Dependencies.cmake#L226

So I have no idea...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BLAS is being picked up correctly, but it is complaining about BLAS_LIBRARIES

export USE_MKLDNN=0
# There is a problem with pkg-config
# See https://github.com/conda-forge/pkg-config-feedstock/issues/38
Expand Down
3 changes: 1 addition & 2 deletions recipe/meta.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{% set version = "2.0.0" %}
{% set number = 0 %}
{% set number = 1 %}

{% if cuda_compiler_version != "None" %}
{% set number = number + 200 %}
Expand Down Expand Up @@ -83,7 +83,6 @@ outputs:
- libcblas * *_mkl # [x86]
- libcblas # [not x86]
- liblapack # [not x86]
- openblas # [not x86]
- libgomp # [linux]
- llvm-openmp # [osx]
- libprotobuf
Expand Down