-
-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use generic blas for building #167
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
What other blas is there? |
maybe for this... conda-forge/numpy-feedstock#253 (comment) The idea is to enable this: https://conda-forge.org/docs/maintainer/knowledge_base.html#switching-blas-implementation |
Not maybe, definitely. ;-) Building against our reference-lapack allows switching out the blas/lapack implementation at environment creation time (as described in the link you posted), and ideally, all feedstocks depending on blas/lapack should be built this way. |
@@ -84,7 +84,7 @@ if [[ "$OSTYPE" == "darwin"* ]]; then | |||
export USE_DISTRIBUTED=1 | |||
|
|||
if [[ "$target_platform" == "osx-arm64" ]]; then | |||
export BLAS=OpenBLAS | |||
export BLAS=Generic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@isuruf should we try generic
(lowercase) here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think BLAS is being picked up correctly, but it is complaining about BLAS_LIBRARIES
Let's add - libcblas # [not x86]
- liblapack # [not x86] to build for the cross-compile case. I think that's what's missing, so let's try it? |
testing in #168 |
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)