Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use generic blas for building #167

Closed
wants to merge 1 commit into from
Closed

Conversation

isuruf
Copy link
Member

@isuruf isuruf commented Apr 16, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@hmaarrfk
Copy link
Contributor

What other blas is there?

@ngam
Copy link
Contributor

ngam commented Apr 16, 2023

What other blas is there?

maybe for this... conda-forge/numpy-feedstock#253 (comment)

The idea is to enable this: https://conda-forge.org/docs/maintainer/knowledge_base.html#switching-blas-implementation

@h-vetinari
Copy link
Member

What other blas is there?

maybe for this... conda-forge/numpy-feedstock#253 (comment)

Not maybe, definitely. ;-)

Building against our reference-lapack allows switching out the blas/lapack implementation at environment creation time (as described in the link you posted), and ideally, all feedstocks depending on blas/lapack should be built this way.

@@ -84,7 +84,7 @@ if [[ "$OSTYPE" == "darwin"* ]]; then
export USE_DISTRIBUTED=1

if [[ "$target_platform" == "osx-arm64" ]]; then
export BLAS=OpenBLAS
export BLAS=Generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think BLAS is being picked up correctly, but it is complaining about BLAS_LIBRARIES

@ngam
Copy link
Contributor

ngam commented Apr 20, 2023

Let's add

        - libcblas              # [not x86]
        - liblapack             # [not x86]

to build for the cross-compile case. I think that's what's missing, so let's try it?

@ngam
Copy link
Contributor

ngam commented Apr 20, 2023

testing in #168

@isuruf isuruf closed this Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants