Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

do not omit frame pointer on Linux #740

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
libuuid:
- '2'
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- x86_64-apple-darwin13.4.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- x86_64-apple-darwin13.4.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- x86_64-apple-darwin13.4.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- x86_64-apple-darwin13.4.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- arm64-apple-darwin20.0.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- arm64-apple-darwin20.0.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- arm64-apple-darwin20.0.0
ncurses:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
macos_machine:
- arm64-apple-darwin20.0.0
ncurses:
Expand Down
2 changes: 2 additions & 0 deletions .ci_support/win_64_freethreadingno.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ freethreading:
- 'no'
libffi:
- '3.4'
liblzma_devel:
- '5'
openssl:
- '3'
pin_run_as_build:
Expand Down
2 changes: 2 additions & 0 deletions .ci_support/win_64_freethreadingyes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,8 @@ freethreading:
- 'yes'
libffi:
- '3.4'
liblzma_devel:
- '5'
openssl:
- '3'
pin_run_as_build:
Expand Down
9 changes: 9 additions & 0 deletions recipe/build_base.sh
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,15 @@ if [[ ${HOST} =~ .*darwin.* ]] && [[ -n ${CONDA_BUILD_SYSROOT} ]]; then
CPPFLAGS="-isysroot ${CONDA_BUILD_SYSROOT} "${CPPFLAGS}
fi

if [[ "$target_platform" == linux-* ]]; then
# For https://docs.python.org/3/howto/perf_profiling.html#how-to-obtain-the-best-results
CFLAGS+=" -fno-omit-frame-pointer"
if [[ "$target_platform" != linux-ppc64le ]]; then
# -mno-omit-leaf-frame-pointer is not supported on ppc64le
CFLAGS+=" -mno-omit-leaf-frame-pointer"
fi
fi

# Debian uses -O3 then resets it at the end to -O2 in _sysconfigdata.py
if [[ ${_OPTIMIZED} = yes ]]; then
CPPFLAGS=$(echo "${CPPFLAGS}" | sed "s/-O2/-O3/g")
Expand Down
4 changes: 3 additions & 1 deletion recipe/meta.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
{% set ver2 = '.'.join(version.split('.')[0:2]) %}
{% set ver2nd = ''.join(version.split('.')[0:2]) %}
{% set ver3nd = ''.join(version.split('.')[0:3]) %}
{% set build_number = 2 %}
{% set build_number = 3 %}

# this makes the linter happy
{% set channel_targets = channel_targets or 'conda-forge main' %}
Expand Down Expand Up @@ -264,6 +264,8 @@ outputs:
- python -c "from ctypes import CFUNCTYPE; CFUNCTYPE(None)(id)"
# Test for wide character supported via ncursesw
- TERM=xterm >/dev/null python -c "import curses; scr = curses.initscr(); curses.unget_wch('x'); assert 'x' == scr.get_wch()" # [unix]
# Test for https://docs.python.org/3/howto/perf_profiling.html#how-to-obtain-the-best-results
- python -m sysconfig | grep 'no-omit-frame-pointer' # [linux]

- name: libpython-static
script: build_static.sh # [unix]
Expand Down
Loading