-
-
Notifications
You must be signed in to change notification settings - Fork 105
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
do not omit frame pointer on Linux #740
base: main
Are you sure you want to change the base?
Conversation
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
This is ready for review. A bit more context for not omitting the frame pointer: https://fedoraproject.org/wiki/Changes/fno-omit-frame-pointer |
I'm generally in favor of it but asking myself whether we should set this globally in the compiler activation? |
FWIW, I'd be in favor of this as a (longer-term?) goal. In the meantime, would it make sense to add this flag just to this feedstock (at least for Python 3.12+)? |
18df359
to
05ec225
Compare
@conda-forge-admin, please rerender |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12187916771. Examine the logs at this URL for more detail. |
Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do. This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12187924818. Examine the logs at this URL for more detail. |
Addresses #688.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase@conda-forge-admin, please rerender
in a comment in this PR for automated rerendering)