Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some missing builds #32

Merged
merged 11 commits into from
Dec 11, 2023
Merged

Conversation

RaulPPelaez
Copy link
Contributor

@RaulPPelaez RaulPPelaez commented Dec 11, 2023

Checklist

  • Used a personal fork of the feedstock to propose changes
  • Bumped the build number (if the version is unchanged)
  • Reset the build number to 0 (if the version changed)
  • Re-rendered with the latest conda-smithy (Use the phrase @conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
  • Ensured the license file is being packaged.

A skip in the meta.yaml file was preventing any CUDA version other than 11.2 from building. This made it so both #30 and #28 just did not built the corresponding CUDA versions. This PR adds them by removing the skip.
Closes #31

@conda-forge-webservices
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@RaulPPelaez RaulPPelaez mentioned this pull request Dec 11, 2023
5 tasks
@RaulPPelaez
Copy link
Contributor Author

@mikemhenry, this includes all missing CUDA 11.8 and CUDA 12 builds in addition to the pytorch 2.1 migrator.
I could not build the combination CUDA 12 + pytorch 2.0.0 because torchani==2.2.4 does not provide it. I do not think this is a problem, though.

Please review!

@mikemhenry mikemhenry merged commit b37e978 into conda-forge:main Dec 11, 2023
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants